Skip to content

[stable2409] Backport #5644#5651

Merged
ggwpez merged 2 commits intostable2409from
backport-5644-to-stable2409
Sep 9, 2024
Merged

[stable2409] Backport #5644#5651
ggwpez merged 2 commits intostable2409from
backport-5644-to-stable2409

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Sep 9, 2024

Backport #5644 into stable2409 (cc @bkchr).

Prevent allocations when calculating the weights.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
(cherry picked from commit f4eb417)
@github-actions github-actions bot requested a review from a team as a code owner September 9, 2024 12:54
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 9, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Sep 9, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@ggwpez ggwpez merged commit 3b9bb9b into stable2409 Sep 9, 2024
@ggwpez ggwpez deleted the backport-5644-to-stable2409 branch September 9, 2024 18:08
github-merge-queue bot pushed a commit that referenced this pull request Sep 10, 2024
The backport bot does currently not trigger the CI when opening a MR,
like here: #5651
Devs need to push an empty commit manually. Now using a token that will
also trigger the CI.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Sep 10, 2024
The backport bot does currently not trigger the CI when opening a MR,
like here: paritytech#5651
Devs need to push an empty commit manually. Now using a token that will
also trigger the CI.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Sep 10, 2024
The backport bot does currently not trigger the CI when opening a MR,
like here: paritytech#5651
Devs need to push an empty commit manually. Now using a token that will
also trigger the CI.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants