Merged
Conversation
Previously, block gaps could only be created by warp sync, but with upcoming changes (paritytech#5406), block gaps will also be generated by fast sync, thus `BlockGapType` is needed. This refactor converts the existing `(NumberFor<Block>, NumberFor<Block>)` into a dedicated `BlockGap<NumberFor<Block>>` struct. This change is purely structural and does not alter existing logic, but it lays the groundwork for future changes.
This commit introduces changes to address compatibility issues resulting from the transition from the old block gap representation `(NumberFor<Block>, NumberFor<Block>)` to the new `BlockGap<NumberFor<Block>>` structure.
dmitry-markin
approved these changes
Sep 5, 2024
Contributor
dmitry-markin
left a comment
dmitry-markin
left a comment
There was a problem hiding this comment.
Looks pretty good, thank you!
bkchr
approved these changes
Sep 6, 2024
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, block gaps could only be created by warp sync, but block gaps will also be generated by fast sync once #5406 is fixed. This PR is part 1 of the detailed implementation plan in #5406 (comment): refactor
BlockGap.This refactor converts the existing
(NumberFor<Block>, NumberFor<Block>)into a dedicatedBlockGap<NumberFor<Block>>struct. This change is purely structural and does not alter existing logic, but lays the groundwork for the follow-up PR.The compatibility concern caused by the new structure is addressed in the second commit.
cc @dmitry-markin