Skip to content

Update approval-voting-regression-bench #5504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexggh merged 3 commits into from
Aug 28, 2024
Merged

Update approval-voting-regression-bench #5504

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd0ff8d
Update approval-voting-regression-bench
alexggh Aug 27, 2024
f83fef6
Update reference
alexggh Aug 28, 2024
ad0cd0b
Update comment
alexggh Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions polkadot/node/core/approval-voting/benches/approval-voting-regression-bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,12 @@ fn main() -> Result<(), String> {
.map_err(|e| e.to_string())?;
println!("{}", average_usage);

// We expect no variance for received and sent
// but use 0.001 because we operate with floats
// We expect some small variance for received and sent because the
// test messages are generated at every benchmark run and they contain
// random data so use 0.01 as the accepted variance.
messages.extend(average_usage.check_network_usage(&[
("Received from peers", 52941.6071, 0.001),
("Sent to peers", 63810.1859, 0.001),
("Received from peers", 52941.6071, 0.01),
("Sent to peers", 63995.2200, 0.01),
]));
messages.extend(average_usage.check_cpu_usage(&[
("approval-distribution", 6.3912, 0.1),
Expand Down