pallet-collator-selection: correctly register weight in new_session#5430
Merged
bkchr merged 6 commits intoparitytech:masterfrom Aug 24, 2024
Merged
pallet-collator-selection: correctly register weight in new_session#5430bkchr merged 6 commits intoparitytech:masterfrom
new_session#5430bkchr merged 6 commits intoparitytech:masterfrom
Conversation
added 2 commits
August 21, 2024 10:24
moliholy
changed the title
new_sessionnew_session
moliholy
changed the title
new_session
added 2 commits
August 21, 2024 10:55
moliholy
changed the title
Contributor
georgepisaltu
left a comment
georgepisaltu
left a comment
There was a problem hiding this comment.
Good catch! A couple of comments but otherwise looks good.
georgepisaltu
added
the
T2-pallets
georgepisaltu
approved these changes
Aug 21, 2024
Contributor
georgepisaltu
left a comment
georgepisaltu
left a comment
There was a problem hiding this comment.
Please update the PR title as well.
moliholy
changed the title
new_session
Contributor
Author
Done! |
joepetrowski
approved these changes
Aug 21, 2024
acatangiu
approved these changes
Aug 21, 2024
bkchr
approved these changes
Aug 24, 2024
ordian
added a commit
that referenced
this pull request
Aug 27, 2024
* master: (36 commits) Bump the ci_dependencies group across 1 directory with 2 updates (#5401) Remove deprecated calls in cumulus-parachain-system (#5439) Make the PR template a default for new PRs (#5462) Only log the propagating transactions when they are not empty (#5424) [CI] Fix SemVer check base commit (#5361) Sync status refactoring (#5450) Add build options to the srtool build step (#4956) `MaybeConsideration` extension trait for `Consideration` (#5384) Skip slot before creating inherent data providers during major sync (#5344) Add symlinks for code of conduct and contribution guidelines (#5447) pallet-collator-selection: correctly register weight in `new_session` (#5430) Derive `Clone` on `EncodableOpaqueLeaf` (#5442) Moving `Find FAIL-CI` check to GHA (#5377) Remove panic, as proof is invalid. (#5427) Reactive syncing metrics (#5410) [bridges] Prune messages from confirmation tx body, not from the on_idle (#5006) Change the chain to Rococo in the parachain template Zombienet config (#5279) Improve the appearance of crates on `crates.io` (#5243) Add initial version of `pallet_revive` (#5293) Update OpenZeppelin template documentation (#5398) ...
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pallet-collator-selectionis not correctly using the weight for the new_session function.The first parameter is the removed candidates, and the second one the original number of candidates before the removal, but both values are swapped.