Added SetAssetClaimer instruction by x3c41a · Pull Request #5416 · paritytech/polkadot-sdk

x3c41a · 2024-08-20T12:20:22Z

For now only implementation.
The tests will follow-up.

polkadot/xcm/xcm-executor/src/lib.rs

polkadot/xcm/src/v5/mod.rs

acatangiu · 2024-08-20T13:25:18Z

polkadot/xcm/xcm-executor/src/lib.rs

 	transact_status: MaybeErrorCode,
 	fees_mode: FeesMode,
 	_config: PhantomData<Config>,
+	assetClaimer: Option<Location>,


We're using CamelCase for struct names, and snake_case for variable/member names.

Suggested change

assetClaimer: Option<Location>,

asset_claimer: Option<Location>,

Please check
https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md
and
https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/STYLE_GUIDE.md
for more contributor info.

tip: cargo can do most of the style formatting for you. Just run cargo fmt -p <crate-name> or cargo fmt --all.
In our case you should use the nightly version for formatting for some advanced linters we use: cargo +nightly fmt -p <crate-name>

cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/xcm/mod.rs

polkadot/xcm/src/v4/mod.rs

polkadot/xcm/xcm-executor/src/lib.rs

acatangiu · 2024-08-21T15:59:25Z

polkadot/xcm/xcm-executor/src/lib.rs

+					// TODO: modify the message by adding setAssetClaimer. 
+					// replicate for teleport and regular withdraw functions.
+					// add e2e tests. 


We need to decide if we want to implicitly propagate the asset claimer location to forwarded XCMs, or we let the XCM builders explicitly configure it for each XCM run at each hop.

Aka, do we need to add it here, or expect the caller to have added it in xcm param (if they wanted a custom claimer on dest as well).

I am leaning towards the latter.

…to mock

…rrier

…th PayFees

…coco --target_dir=polkadot --pallet=pallet_xcm_benchmarks::generic

…stend --target_dir=polkadot --pallet=pallet_xcm_benchmarks::generic

…retime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic

command-bot · 2024-09-04T08:19:55Z

@x3c41a https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248505 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=people-westend --runtime_dir=people --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 12-8a6b9390-292a-44ca-9d48-c94b15b6d4f6 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-09-04T08:19:59Z

@x3c41a https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248506 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=people-rococo --runtime_dir=people --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-fe70ee96-93ae-43ea-a184-2f55243db2b1 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-09-04T08:22:24Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=rococo --target_dir=polkadot --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248496 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248496/artifacts/download.

command-bot · 2024-09-04T08:22:31Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248495 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248495/artifacts/download.

command-bot · 2024-09-04T08:22:34Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=asset-hub-westend --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248498 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248498/artifacts/download.

command-bot · 2024-09-04T08:22:38Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=people-rococo --runtime_dir=people --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248506 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248506/artifacts/download.

command-bot · 2024-09-04T08:22:43Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248501 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248501/artifacts/download.

command-bot · 2024-09-04T08:22:47Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=asset-hub-rococo --runtime_dir=assets --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248499 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248499/artifacts/download.

command-bot · 2024-09-04T08:22:51Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248500 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248500/artifacts/download.

command-bot · 2024-09-04T08:22:54Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=bridge-hub-rococo --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248502 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248502/artifacts/download.

command-bot · 2024-09-04T08:23:02Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=bridge-hub-westend --runtime_dir=bridge-hubs --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248503 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248503/artifacts/download.

command-bot · 2024-09-04T08:23:05Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=people-westend --runtime_dir=people --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248505 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248505/artifacts/download.

command-bot · 2024-09-04T08:23:12Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=contracts-rococo --runtime_dir=contracts --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248504 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7248504/artifacts/download.

x3c41a · 2024-09-04T08:56:10Z

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

command-bot · 2024-09-04T08:56:15Z

@x3c41a https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7249095 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm_benchmarks::generic. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 14-17ec3c6e-6b82-43da-a88b-b9e9077ac463 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-09-04T08:59:25Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7249095 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7249095/artifacts/download.

paritytech-cicd-pr · 2024-09-04T09:24:11Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7249411

x3c41a · 2024-09-05T07:02:34Z

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

command-bot · 2024-09-05T07:02:39Z

@x3c41a https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7261652 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm_benchmarks::generic. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 18-e761bbe5-a639-4df1-a17d-f312a0557726 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-09-05T07:05:19Z

@x3c41a Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=westend --target_dir=polkadot --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7261652 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7261652/artifacts/download.

franciscoaguirre · 2024-10-21T20:31:01Z

Closing in favor of #5585

x3c41a requested a review from a team as a code owner August 20, 2024 12:20

x3c41a added the T6-XCM This PR/Issue is related to XCM. label Aug 20, 2024

x3c41a requested review from acatangiu and franciscoaguirre August 20, 2024 12:51

franciscoaguirre force-pushed the xcm-v5 branch from 9bec263 to 1f031ec Compare August 20, 2024 13:07

x3c41a force-pushed the xcm-v5-custom-asset-claimer branch from f6ea907 to adf6e83 Compare August 20, 2024 13:23

acatangiu reviewed Aug 20, 2024

View reviewed changes

feat(xcm): add PayFees instruction

3d7e24a

franciscoaguirre reviewed Aug 21, 2024

View reviewed changes

cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/xcm/mod.rs Outdated Show resolved Hide resolved

polkadot/xcm/src/v4/mod.rs Outdated Show resolved Hide resolved

polkadot/xcm/xcm-executor/src/lib.rs Outdated Show resolved Hide resolved

acatangiu reviewed Aug 21, 2024

View reviewed changes

franciscoaguirre and others added 20 commits August 21, 2024 18:20

chore(xcm-executor): clean up executor unit test and move everything …

0a88320

…to mock

Merge branch 'xcm-v5' into xcm-pay-fees

0b16ca5

feat(xcm-executor): tests for delivery fees and old BuyExecution

2393087

feat(xcm-executor): interaction between PayFees and RefundSurplus

b9ca9e0

fix(xcm): add builder(pays_fees) to old xcm versions

22efce5

chore(xcm-executor): unhappy tests for PayFees

49f63a4

chore(xcm-executor): test that leftover fees are also trapped

50b06d6

chore: add made-up benchmarks to all runtimes

738a8c1

feat(xcm-builder): allow PayFees in AllowTopLevelPaidExecutionFrom ba…

995cc09

…rrier

feat(xcm-executor): use fees register in DepositReserveAsset

679c3c7

feat(xcm-emulator): add set_call method for dispatching calls

d934c64

test(asset-hub-westend-integration-tests): add xcm estimation test wi…

52f3ba1

…th PayFees

fix: fmt

900bb46

fix(xcm-executor): remove unnecessary clones

56bcd4d

chore(asset-hub-westend-integration-tests): refactor test to decl macro

c062c0c

feat(asset-hub-rococo-integration-tests): add PayFees test

94f831f

fix: fmt

3198950

".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=ro…

6bf562b

…coco --target_dir=polkadot --pallet=pallet_xcm_benchmarks::generic

".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=we…

15a5333

…stend --target_dir=polkadot --pallet=pallet_xcm_benchmarks::generic

".git/.scripts/commands/bench/bench.sh" --subcommand=xcm --runtime=co…

fb79e69

…retime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic

merged into xcm-pay-fees branch

358544e

x3c41a requested review from a team, athei and koute as code owners September 4, 2024 09:18

franciscoaguirre force-pushed the xcm-pay-fees branch from 3066f6f to f0f1aac Compare September 4, 2024 14:37

Base automatically changed from xcm-pay-fees to xcm-v5 October 17, 2024 12:35

franciscoaguirre closed this Oct 21, 2024

franciscoaguirre deleted the xcm-v5-custom-asset-claimer branch October 21, 2024 20:31

	assetClaimer: Option<Location>,
	asset_claimer: Option<Location>,

Conversation

x3c41a commented Aug 20, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acatangiu Aug 20, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

acatangiu Aug 21, 2024

Choose a reason for hiding this comment

Uh oh!

command-bot bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

x3c41a commented Sep 4, 2024

Uh oh!

command-bot bot commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Sep 4, 2024

Uh oh!

paritytech-cicd-pr commented Sep 4, 2024

Uh oh!

x3c41a commented Sep 5, 2024

Uh oh!

command-bot bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Sep 5, 2024

Uh oh!

franciscoaguirre commented Oct 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

command-bot bot commented Sep 4, 2024 •

edited

Loading

command-bot bot commented Sep 4, 2024 •

edited

Loading

command-bot bot commented Sep 4, 2024 •

edited

Loading

command-bot bot commented Sep 5, 2024 •

edited

Loading