Use umbrella crate for minimal template#5155
Merged
kianenigma merged 59 commits intomasterfrom Aug 28, 2024
Merged
Conversation
pgherveou
added
R0-no-crate-publish-required
Member
|
Some of the clippy warnings seem to come from the |
Contributor
Author
Yeah this is weird as the experimental feature seems to be propagated correctly, clippy works fine locally too 🤔 |
bkchr
reviewed
Jul 27, 2024
kianenigma
reviewed
Aug 5, 2024
kianenigma
requested changes
Aug 5, 2024
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
I think we are waiting for a new release before we can merge this?
also would like to see https://github.com/paritytech/polkadot-sdk/pull/5155/files#r1703858118 addressed.
This was referenced Aug 5, 2024
kianenigma
reviewed
Aug 6, 2024
kianenigma
reviewed
Aug 7, 2024
kianenigma
approved these changes
Aug 13, 2024
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Made a few fixes me self now, and now it is all good!
pgherveou
commented
Aug 27, 2024
Contributor
Author
There was a problem hiding this comment.
note to self: maybe this can be rolled back as well
kianenigma
reviewed
Aug 27, 2024
athei
approved these changes
Aug 28, 2024
Member
athei
left a comment
athei
left a comment
There was a problem hiding this comment.
I think with this we kill two birds with one stone. Cut down on compile times for our users and fix our CI.
serban300
approved these changes
Aug 28, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
Co-authored-by: kianenigma <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
ordian
added a commit
that referenced
this pull request
Aug 29, 2024
* master: (39 commits) short-term fix for para inherent weight overestimation (#5082) CI: Add backporting bot (#4795) Fix benchmark failures when using `insecure_zero_ed` flag (#5354) Command bot GHA v2 - /cmd <cmd> (#5457) Remove pallet::getter usage from treasury (#4962) Bump blake2b_simd from 1.0.1 to 1.0.2 (#5404) Bump rustversion from 1.0.14 to 1.0.17 (#5405) Bridge zombienet tests: remove old command (#5434) polkadot-parachain: Add omni-node variant with u64 block number (#5269) Refactor verbose test (#5506) Use umbrella crate for minimal template (#5155) IBP Coretime Polkadot bootnodes (#5499) rpc server: listen to `ipv6 socket` if available and `--experimental-rpc-endpoint` CLI option (#4792) Update approval-voting-regression-bench (#5504) change try-runtime rpc domains (#5443) polkadot-parachain-bin: Remove contracts parachain (#5471) Add feature to allow Aura collator to use full PoV size (#5393) Adding stkd bootnodes (#5470) Make `PendingConfigs` storage item public (#5467) frame-omni-bencher maintenance (#5466) ...
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.