Skip to content

Add from_mel for Footprint with a Test#5132

Merged
bkchr merged 8 commits intomasterfrom
shawntabrizi-footprint-from-mel
Jul 26, 2024
Merged

Add from_mel for Footprint with a Test#5132
bkchr merged 8 commits intomasterfrom
shawntabrizi-footprint-from-mel

Conversation

@shawntabrizi
Copy link
Copy Markdown
Member

@shawntabrizi shawntabrizi commented Jul 24, 2024 •
edited
Loading

We may want to construct a Footprint by taking the max_encoded_len of a type, without having to construct the type.

This impl allows easy access to that.

@shawntabrizi shawntabrizi requested a review from a team as a code owner July 24, 2024 20:00
ggwpez
ggwpez approved these changes Jul 24, 2024
View reviewed changes
@ggwpez ggwpez added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Jul 25, 2024
@ggwpez ggwpez requested a review from a team July 25, 2024 11:09
@bkchr
Copy link
Copy Markdown
Member

bkchr commented Jul 26, 2024

bot fmt

@command-bot
Copy link
Copy Markdown

command-bot bot commented Jul 26, 2024 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6819983 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-dfa15859-2f9c-4c57-b0c8-5e31d105d0d1 to cancel this command or bot cancel to cancel all commands in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 26, 2024

We are migrating the command bot to be a GitHub Action

Please, see the documentation on how to use it

@command-bot
Copy link
Copy Markdown

command-bot bot commented Jul 26, 2024

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6819983 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6819983/artifacts/download.

@bkchr bkchr enabled auto-merge July 26, 2024 08:29
@bkchr bkchr added this pull request to the merge queue Jul 26, 2024
Merged via the queue into master with commit 90b5533 Jul 26, 2024
@bkchr bkchr deleted the shawntabrizi-footprint-from-mel branch July 26, 2024 09:28
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@shawntabrizi @bkchr @TarekkMA
Add from_mel for Footprint with a Test (paritytech#5132)
557b7c0 
We may want to construct a `Footprint` by taking the `max_encoded_len`
of a type, without having to construct the type.

This impl allows easy access to that.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: command-bot <>
@ggwpez ggwpez mentioned this pull request Sep 9, 2024
Closed
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Closed
@TDemeco TDemeco mentioned this pull request Oct 14, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr bkchr approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees

No one assigned

Labels

T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

[preview] release tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shawntabrizi @bkchr @ggwpez @pgherveou