add possibility to inject non-authorities session-keys in genesis by girazoki · Pull Request #5078 · paritytech/polkadot-sdk

girazoki · 2024-07-19T12:54:12Z

Add the possibility of injecting session-keys in genesis for non-validators. Currently all keys injected in genesis were considered as part of the initial validators set, this PR allows to inject a new vector with non-authority keys

substrate/frame/session/src/lib.rs

davxy

Technically looks good

davxy · 2024-07-22T09:38:25Z

substrate/frame/session/src/lib.rs

+		/// List of (AccountId, ValidatorId, Keys) that will be registered at genesis, but not as active validators.
+		pub non_authority_keys: Vec<(T::AccountId, T::ValidatorId, T::Keys)>,


IMO is worth being explicit that these keys (together with keys) will end up in the NextKeys set. I.e. keys that are registered as candidates for session after next session (session # 2).

And technically these are still authorities (well, authority candidates). So maybe a more appropriate name? Don't know registered_candidates? But naming is hard so I may be biased :-D

I disagree, non_authority_keys are not necessarily authorities, whether they will be authorities it will be decided by SessionManager (even in the session # 2). Just for having keys registered they will not be authorities, unless they SessionManager decides to select them.

As for the naming, I am fine with anything as I am not too biased around it.

Well.

I agree that these are not necessarily actual authorities, indeed I put in bold that are candidates.

This is not my opinion, if I've not overlooked something, this is just a fact. The inner_set_keys is called, which calls put_keys, which stores your non_authority_keys in NextKeys set, which are the candidates registered

So I still think is worth being explicit about what is the usage of this non_authority_keys list. Otherwise as a user the doc is not super clear.

ah got it. Yeah I can add more clarity on that for sure!

Alright so I added a comment saying that these keys are valid at least until session 2 (maybe valid is not the best word here?), but basically my intention is to say that if there is a session-key change, the first session that would pick these new keys is session number 3

substrate/frame/session/src/lib.rs

prdoc/pr_5078.prdoc

bkchr · 2024-07-22T20:05:16Z

@girazoki CI is not happy.

girazoki · 2024-07-23T07:35:01Z

@girazoki CI is not happy.

will check

…n-validator-keys

bkchr · 2024-07-23T08:00:22Z

@girazoki also clippy was failing: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6772111

bkchr · 2024-07-24T09:15:56Z

@girazoki CI is still not happy :D

girazoki · 2024-07-26T07:21:00Z

@girazoki CI is still not happy :D

I am really trying xD. Let's see this time

bkchr · 2024-07-29T09:03:13Z

Also check-semver is still failing 🙈

girazoki · 2024-07-29T12:58:10Z

Also check-semver is still failing 🙈

That should be easy I think 😄

girazoki · 2024-07-29T13:54:51Z

Also check-semver is still failing 🙈

Or maybe not 🙈, why is semver telling me the crates are not listed in the pr-doc when they are?

bkchr · 2024-07-29T14:10:41Z

Also check-semver is still failing 🙈

Or maybe not 🙈, why is semver telling me the crates are not listed in the pr-doc when they are?

Ahh yeah there was a bug with none. It got fixed, not sure it is already in CI.

…ritytech#5078) Add the possibility of injecting session-keys in genesis for non-validators. Currently all keys injected in genesis were considered as part of the initial validators set, this PR allows to inject a new vector with non-authority keys --------- Co-authored-by: Bastian Köcher <git@kchr.de>

* Initialize * Companion for paritytech/polkadot-sdk#4977 * Companion for paritytech/polkadot-sdk#5078 * Companion for paritytech/polkadot-sdk#5214 * Companion for paritytech/polkadot-sdk#5431 * Companion for paritytech/polkadot-sdk#4792 * Companion for paritytech/polkadot-sdk#5613 * Companion for paritytech/polkadot-sdk#7688 * Fixes * Companion for paritytech/polkadot-sdk#5364 * Fixes * Disable storage limit & fix format issue * Benchmark only * Patch evm * Update patch info * Fixes --------- Co-authored-by: bear <boundless.forest@outlook.com>

girazoki added 2 commits July 19, 2024 14:13

add possibility to inject non-authorities session-keys in genesis

80719e9

just single cloned

1e5c9b2

girazoki requested a review from a team as a code owner July 19, 2024 12:54

bkchr approved these changes Jul 19, 2024

View reviewed changes

substrate/frame/session/src/lib.rs Show resolved Hide resolved

substrate/frame/session/src/lib.rs Outdated Show resolved Hide resolved

bkchr added T1-FRAME This PR/Issue is related to core FRAME, the framework. T2-pallets This PR/Issue is related to a particular pallet. and removed T1-FRAME This PR/Issue is related to core FRAME, the framework. labels Jul 19, 2024

girazoki added 2 commits July 22, 2024 09:44

changes

8a019db

prdoc

2d4b35b

davxy reviewed Jul 22, 2024

View reviewed changes

davxy approved these changes Jul 22, 2024

View reviewed changes

improve commets

5eefddc

davxy reviewed Jul 22, 2024

View reviewed changes

substrate/frame/session/src/lib.rs Outdated Show resolved Hide resolved

more comments

91c5402

bkchr reviewed Jul 22, 2024

View reviewed changes

prdoc/pr_5078.prdoc Outdated Show resolved Hide resolved

bkchr added 2 commits July 22, 2024 21:52

Apply suggestions from code review

3c5f073

Merge branch 'master' into girazoki-genesis-non-validator-keys

b4ae933

bkchr enabled auto-merge July 22, 2024 19:53

make prdoc hppy

802a7f0

auto-merge was automatically disabled July 23, 2024 07:41
Head branch was pushed to by a user without write access

Merge remote-tracking branch 'origin/master' into girazoki-genesis-no…

d6be583

…n-validator-keys

girazoki added 2 commits July 23, 2024 10:09

make prdoc happy again

c1f345f

add default for tests

4ea650c

more fixes

707df69

girazoki requested a review from acatangiu as a code owner July 26, 2024 07:21

fix failing test

1420621

auto-merge was automatically disabled July 29, 2024 08:46
Head branch was pushed to by a user without write access

prdoc

395e9b6

Merge branch 'master' into girazoki-genesis-non-validator-keys

e585289

bkchr added this pull request to the merge queue Jul 29, 2024

Merged via the queue into paritytech:master with commit d6f5987 Jul 29, 2024

ggwpez mentioned this pull request Sep 9, 2024

Parent issue for stable2409 LTS release #5583

Closed

github-actions bot mentioned this pull request Oct 8, 2024

Update polkadot-sdk from stable2407 to stable2409 moonbeam-foundation/moonbeam#2994

Closed

franciscoaguirre mentioned this pull request Oct 14, 2024

Dry run xcms on bridge hubs to get forwarded xcms across the W<>R bridge #6002

Open

2 tasks

TDemeco mentioned this pull request Oct 14, 2024

feat: ⏫ upgrade to Polkadot SDK stable2409 Moonsong-Labs/storage-hub#228

Merged

github-actions bot mentioned this pull request Dec 5, 2024

Update polkadot-sdk from stable2407 to stable2409-2 moonbeam-foundation/moonbeam#3075

Closed

aurexav added a commit to darwinia-network/darwinia that referenced this pull request May 29, 2025

Companion for paritytech/polkadot-sdk#5078

be47687

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 20, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

pgherveou added this to [preview] release tracker Mar 23, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 23, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 23, 2026

		/// List of (AccountId, ValidatorId, Keys) that will be registered at genesis, but not as active validators.
		pub non_authority_keys: Vec<(T::AccountId, T::ValidatorId, T::Keys)>,

Conversation

girazoki commented Jul 19, 2024

Uh oh!

Uh oh!

Uh oh!

davxy left a comment

Choose a reason for hiding this comment

Uh oh!

davxy Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

girazoki Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davxy Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

girazoki Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

girazoki Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bkchr commented Jul 22, 2024

Uh oh!

girazoki commented Jul 23, 2024

Uh oh!

bkchr commented Jul 23, 2024

Uh oh!

bkchr commented Jul 24, 2024

Uh oh!

girazoki commented Jul 26, 2024

Uh oh!

bkchr commented Jul 29, 2024

Uh oh!

girazoki commented Jul 29, 2024

Uh oh!

girazoki commented Jul 29, 2024

Uh oh!

bkchr commented Jul 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

girazoki Jul 22, 2024 •

edited

Loading

davxy Jul 22, 2024 •

edited

Loading