Merged
Conversation
…olkadot-sdk into snowbridge-on-westend
Contributor
|
@yrong you need to add a prdoc for this PR, some examples here: https://github.com/paritytech/polkadot-sdk/tree/master/prdoc It's a simple markdown file (should be called pr_5074.prdoc in this case), describing the change. :) |
…olkadot-sdk into snowbridge-on-westend
acatangiu
added
T14-system_parachains
serban300
approved these changes
Aug 2, 2024
acatangiu
approved these changes
Aug 6, 2024
| fn is_waived(origin: Option<&Location>, fee_reason: FeeReason) -> bool { | ||
| let Some(loc) = origin else { return false }; | ||
| if let Export { network, destination: Here } = fee_reason { | ||
| return !(network == EthereumNetwork::get()) |
Contributor
There was a problem hiding this comment.
Don't short-circuit when export network is not Ethereum.
Suggested change
| return !(network == EthereumNetwork::get()) | |
| if network == EthereumNetwork::get() { | |
| return false | |
| } |
ordian
added a commit
that referenced
this pull request
Aug 7, 2024
* master: Umbrella crate: exclude chain-specific crates (#5173) Bring reference_hardware.json inline with machine used for weights (#5196) Snowbridge on Westend (#5074) Run semver check even when no prdoc (#5189) Export more from sc-service (#5250) Update the wishlist leaderboard script to handle PRs (#5256)
serban300
reviewed
Aug 9, 2024
| bridge_to_bulletin_config::OnBridgeHubRococoRefundRococoBulletinMessages, | ||
| ), | ||
| cumulus_primitives_storage_weight_reclaim::StorageWeightReclaim<Runtime>, | ||
| frame_metadata_hash_extension::CheckMetadataHash<Runtime>, |
Contributor
There was a problem hiding this comment.
@yrong this breaks the bridge zombienet tests. I can either remove it here or add it to the bridge relayer in order to address this issue. So just wanted to ask if you actually need it here in order to understand how to fix this. The same for bridge hub westend.
Also I think the runtime version should be incremented
Related to: #5296
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
Updating the BHR and BHW runtime versions as a result of the changes in #5074
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Aug 28, 2024
### Context Since Rococo is now deprecated, we need another testnet to detect bleeding-edge changes to Substrate, Polkadot, & BEEFY consensus protocols that could brick the bridge. It's the mirror PR of Snowfork#157 which has reviewed by Snowbridge team internally. Synced with @acatangiu about that in channel https://matrix.to/#/!gxqZwOyvhLstCgPJHO:matrix.parity.io/$N0CvTfDSl3cOQLEJeZBh-wlKJUXx7EDHAuNN5HuYHY4?via=matrix.parity.io&via=parity.io&via=matrix.org --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Aug 28, 2024
Updating the BHR and BHW runtime versions as a result of the changes in paritytech#5074
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
# Description Fix #5074 which missed the runtime migration to initialize channels of the bridge. --------- Co-authored-by: Adrian Catangiu <adrian@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Since Rococo is now deprecated, we need another testnet to detect bleeding-edge changes to Substrate, Polkadot, & BEEFY consensus protocols that could brick the bridge.
It's the mirror PR of Snowfork#157 which has reviewed by Snowbridge team internally.
Synced with @acatangiu about that in channel https://matrix.to/#/!gxqZwOyvhLstCgPJHO:matrix.parity.io/$N0CvTfDSl3cOQLEJeZBh-wlKJUXx7EDHAuNN5HuYHY4?via=matrix.parity.io&via=parity.io&via=matrix.org