Skip to content

pallet-timestamp: UnixTime::now implementation logs error only if called at genesis #5055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkchr merged 4 commits into from
Jul 30, 2024
Merged

pallet-timestamp: UnixTime::now implementation logs error only if called at genesis #5055

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7e2b48
Gates log::error call in timestamp pallet against non-std
gpestana Jul 17, 2024
0095d68
Merge branch 'master' into gpestana/timestamp_err_verbosity
gpestana Jul 30, 2024
05a2d55
reintroduces if statement in the UnixTime::now implementation to log …
gpestana Jul 30, 2024
dde1285
adds prdoc
gpestana Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions substrate/frame/timestamp/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,12 @@ impl<T: Config> UnixTime for Pallet<T> {
// `sp_timestamp::InherentDataProvider`.
let now = Now::<T>::get();

log::error!(
target: "runtime::timestamp",
"`pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0",
);
if now == T::Moment::zero() {
log::error!(
target: "runtime::timestamp",
"`pallet_timestamp::UnixTime::now` is called at genesis, invalid value returned: 0",
);
}

core::time::Duration::from_millis(now.saturated_into::<u64>())
}
Expand Down