Skip to content

litep2p/peerstore: Fix bump last updated time #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexnv merged 2 commits into from
Jul 8, 2024
Merged

litep2p/peerstore: Fix bump last updated time #4971

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b22317
litep2p/peerstore: Bump last updated time
lexnv Jul 8, 2024
d3384cf
Merge branch 'master' into lexnv/peer_store_bump_last_update
lexnv Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion substrate/client/network/src/litep2p/peerstore.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ impl PeerInfo {
self.reputation < BANNED_THRESHOLD
}

fn add_reputation(&mut self, increment: i32) {
self.reputation = self.reputation.saturating_add(increment);
self.bump_last_updated();
}

fn decay_reputation(&mut self, seconds_passed: u64) {
// Note that decaying the reputation value happens "on its own",
// so we don't do `bump_last_updated()`.
Expand All @@ -103,6 +108,10 @@ impl PeerInfo {
}
}
}

fn bump_last_updated(&mut self) {
self.last_updated = Instant::now();
}
}

#[derive(Debug, Default)]
Expand Down Expand Up @@ -169,7 +178,7 @@ impl PeerStoreProvider for PeerstoreHandle {

match lock.peers.get_mut(&peer) {
Some(info) => {
info.reputation = info.reputation.saturating_add(reputation_change.value);
info.add_reputation(reputation_change.value);
},
None => {
lock.peers.insert(
Expand Down