feat: introduce pallet-parameters to Westend to parameterize inflation by marcuspang · Pull Request #4938 · paritytech/polkadot-sdk

marcuspang · 2024-07-03T16:14:05Z

Fixes #4907

Changes

Add pallet-parameters to Westend runtime
Add relay_era_payout function to Polkadot runtime common + deprecate previous era_payout function
- Add unit tests for relay_era_payout, matching previous unit tests for era_payout
Remove pallet_staking_reward_curve in Westend runtime
Add dynamic_params to replace constants used for pallet_staking_reward_curve

Polkadot address: 5DybbVdLvVWd7MiA1YwkzLUNL1ThMDicozbuLc8v9pQEScPQ

cla-bot-2021 · 2024-07-03T16:14:13Z

User @marcuspang, please sign the CLA here.

polkadot/runtime/westend/src/lib.rs

marcuspang · 2024-07-05T14:06:29Z

@kianenigma may I ask how I should benchmark and get the weight info? I'm not sure if I should run it with the Github action to derive the values

kianenigma · 2024-07-08T11:56:20Z

bot help

command-bot · 2024-07-08T11:56:24Z

Here's a link to docs

kianenigma · 2024-07-08T11:58:27Z

bot bench polkadot-pallet --pallet=pallet_parameters --runtime=westend

command-bot · 2024-07-08T11:58:32Z

@kianenigma https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6652919 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_parameters. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-4d068480-b725-4d5d-aef6-ce16e250a21a to cancel this command or bot cancel to cancel all commands in this pull request.

kianenigma · 2024-07-08T11:59:01Z

Let's see if this works :)

polkadot/runtime/common/src/impls.rs

polkadot/runtime/westend/src/lib.rs

command-bot · 2024-07-08T12:20:32Z

@kianenigma Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=westend --target_dir=polkadot --pallet=pallet_parameters has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6652919 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6652919/artifacts/download.

polkadot/runtime/westend/src/lib.rs

…on param

marcuspang · 2024-07-19T14:52:04Z

@marcuspang can you please add your address for a tip to the pr description?

Done!

kianenigma · 2024-07-22T09:43:28Z

/tip medium

substrate-tip-bot · 2024-07-22T09:43:32Z

@marcuspang Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

kianenigma · 2024-07-22T09:44:18Z

/tip medium

kianenigma · 2024-07-22T10:07:03Z

/tip medium

substrate-tip-bot · 2024-07-22T10:07:08Z

@kianenigma Invalid tip size. Please specify one of small, medium, large.

kianenigma · 2024-07-22T10:07:31Z

/tip medium

substrate-tip-bot · 2024-07-22T10:08:02Z

@kianenigma A referendum for a medium (80 DOT) tip was successfully submitted for @marcuspang (5DybbVdLvVWd7MiA1YwkzLUNL1ThMDicozbuLc8v9pQEScPQ on polkadot).

Referendum number: 1021.

substrate-tip-bot · 2024-07-22T10:08:36Z

The referendum has appeared on Polkassembly.

gpestana · 2024-07-22T21:31:14Z

polkadot/runtime/westend/src/lib.rs

+
+	#[cfg(feature = "runtime-benchmarks")]
+	fn try_successful_origin(_key: &RuntimeParametersKey) -> Result<RuntimeOrigin, ()> {
+		// Provide the origin for the parameter returned by `Default`:


Suggested change

// Provide the origin for the parameter returned by `Default`:

// Provide the origin for the parameter returned by `Default`.

gpestana · 2024-07-22T21:36:20Z

polkadot/runtime/common/src/impls.rs

+/// A specialized function to compute the inflation of the staking system, tailored for polkadot
+/// relay chains, such as Polkadot, Kusama and Westend.


Suggested change

/// A specialized function to compute the inflation of the staking system, tailored for polkadot

/// relay chains, such as Polkadot, Kusama and Westend.

/// A specialized function to compute the inflation of the staking system.

Nit but in this runtime it is implicit that the configs/impls are for Westend relay chain.

gpestana · 2024-07-22T21:39:54Z

polkadot/runtime/common/src/impls.rs

 		t.into()
 	}

+	pub fn deprecated_era_payout(


Since this fn is not used anywhere but in the tests, does it need #[allow(dead_code)] to avoid compilation warnings?

I'd probably have moved this implementation and the tests into a mod test_inflation {} as we probably dont use this code in the runtime anymore.

nit but moving this code under a mod gated by cfg(test) also make sense given that in the prdoc, it says that the old era payout impl has been removed :)

Yes, it currently lives under

#[cfg(test)] mod tests {

in L265

* master: Bump slotmap from 1.0.6 to 1.0.7 (#5096) feat: introduce pallet-parameters to Westend to parameterize inflation (#4938) Bump openssl from 0.10.64 to 0.10.66 (#5107) Bump lycheeverse/lychee-action from 1.9.1 to 1.10.0 (#5094) docs: remove the duplicate word (#5095) Prepare PVFs if node is a validator in the next session (#4791) Update parity publish (#5105)

kianenigma · 2024-08-01T12:36:29Z

@ggwpez @EgorPopelyaev what is the way to track "when this will land on westend"? is there a public chat/agenda about when westend gets updated?

paritytech#4938) Fixes paritytech#4907 ## Changes - Add `pallet-parameters` to Westend runtime - Add `relay_era_payout` function to Polkadot runtime common + deprecate previous `era_payout` function - Add unit tests for `relay_era_payout`, matching previous unit tests for `era_payout` - Remove `pallet_staking_reward_curve` in Westend runtime - Add `dynamic_params` to replace constants used for `pallet_staking_reward_curve` Polkadot address: 5DybbVdLvVWd7MiA1YwkzLUNL1ThMDicozbuLc8v9pQEScPQ --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: kianenigma <kian@parity.io> Co-authored-by: command-bot <>

ggwpez · 2024-08-06T13:30:03Z

what is the way to track "when this will land on westend"? is there a public chat/agenda about when westend gets updated?

I think unfortunately there is no way to easily see this. Sometimes devops posts in chat... yea we need some "Release Comms".

feat: setup pallet-parameters in westend runtime

81da185

feat: introduce dynamic params for staking reward params

e84a472

marcuspang commented Jul 3, 2024

View reviewed changes

polkadot/runtime/westend/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Jul 4, 2024

View reviewed changes

polkadot/runtime/westend/src/lib.rs Outdated Show resolved Hide resolved

marcuspang added 2 commits July 5, 2024 00:57

feat: add new era relay payout function

e8d2ec5

feat: add new era payout fn with dynamic params

77a28cc

marcuspang commented Jul 4, 2024

View reviewed changes

polkadot/runtime/westend/src/lib.rs Outdated Show resolved Hide resolved

marcuspang added 5 commits July 5, 2024 21:12

fix: total stakable value + remove NIS

b010d0b

chore: remove unused weight params

30caa8c

build: remove unused reward staking curve pallet

08b9287

chore: remove unused era_payout function

282aa21

chore: leave deprecated function in crate

ff9e782

marcuspang marked this pull request as ready for review July 5, 2024 14:05

Merge branch 'master' into feat/make-westend-inflation-parameterizable

90f031d

kianenigma reviewed Jul 8, 2024

View reviewed changes

polkadot/runtime/common/src/impls.rs Outdated Show resolved Hide resolved

kianenigma reviewed Jul 8, 2024

View reviewed changes

polkadot/runtime/common/src/impls.rs Show resolved Hide resolved

kianenigma reviewed Jul 8, 2024

View reviewed changes

polkadot/runtime/westend/src/lib.rs Show resolved Hide resolved

ggwpez reviewed Jul 8, 2024

View reviewed changes

polkadot/runtime/westend/src/lib.rs Show resolved Hide resolved

ggwpez reviewed Jul 8, 2024

View reviewed changes

polkadot/runtime/westend/src/lib.rs Show resolved Hide resolved

marcuspang added 3 commits July 10, 2024 08:07

test: add unit test to ensure payout logic is same using legacy aucti…

ae01d45

…on param

fix: add allow deprecated macro for tests

aa563f5

fix: missing default trait for runtimeparameters

ae0a72d

Merge branch 'master' into feat/make-westend-inflation-parameterizable

b972461

kianenigma approved these changes Jul 22, 2024

View reviewed changes

kianenigma enabled auto-merge July 22, 2024 09:44

rzadp mentioned this pull request Jul 22, 2024

Make user input less strict paritytech/substrate-tip-bot#161

Closed

2 tasks

gpestana approved these changes Jul 22, 2024

View reviewed changes

kianenigma added this pull request to the merge queue Jul 22, 2024

Merged via the queue into paritytech:master with commit 6e520eb Jul 22, 2024

ggwpez mentioned this pull request Sep 9, 2024

Parent issue for stable2409 LTS release #5583

Closed

github-actions bot mentioned this pull request Oct 8, 2024

Update polkadot-sdk from stable2407 to stable2409 moonbeam-foundation/moonbeam#2994

Closed

github-actions bot mentioned this pull request Dec 5, 2024

Update polkadot-sdk from stable2407 to stable2409-2 moonbeam-foundation/moonbeam#3075

Closed

pgherveou added this to [preview] release tracker Mar 20, 2026

github-project-automation bot moved this to Done in [preview] release tracker Mar 20, 2026

pgherveou removed this from [preview] release tracker Mar 20, 2026

pgherveou added this to [preview] release tracker Mar 23, 2026

github-project-automation bot moved this to Todo in [preview] release tracker Mar 23, 2026

github-project-automation bot moved this from Todo to Done in [preview] release tracker Mar 23, 2026

	// Provide the origin for the parameter returned by `Default`:
	// Provide the origin for the parameter returned by `Default`.

		/// A specialized function to compute the inflation of the staking system, tailored for polkadot
		/// relay chains, such as Polkadot, Kusama and Westend.

Conversation

marcuspang commented Jul 3, 2024 • edited by kianenigma Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

cla-bot-2021 bot commented Jul 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcuspang commented Jul 5, 2024

Uh oh!

kianenigma commented Jul 8, 2024

Uh oh!

command-bot bot commented Jul 8, 2024

Uh oh!

kianenigma commented Jul 8, 2024

Uh oh!

command-bot bot commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kianenigma commented Jul 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

command-bot bot commented Jul 8, 2024

Uh oh!

Uh oh!

Uh oh!

marcuspang commented Jul 19, 2024

Uh oh!

kianenigma commented Jul 22, 2024

Uh oh!

substrate-tip-bot bot commented Jul 22, 2024

Uh oh!

kianenigma commented Jul 22, 2024

Uh oh!

kianenigma commented Jul 22, 2024

Uh oh!

substrate-tip-bot bot commented Jul 22, 2024

Uh oh!

kianenigma commented Jul 22, 2024

Uh oh!

substrate-tip-bot bot commented Jul 22, 2024

Uh oh!

substrate-tip-bot bot commented Jul 22, 2024

Uh oh!

gpestana Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

gpestana Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

gpestana Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

gpestana Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

marcuspang Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

kianenigma commented Aug 1, 2024

Uh oh!

ggwpez commented Aug 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

marcuspang commented Jul 3, 2024 •

edited by kianenigma

Loading

command-bot bot commented Jul 8, 2024 •

edited

Loading