Balances Pallet: Emit events when TI is updated in currency impl#4936
Conversation
|
User @mittal-parth, please sign the CLA here. |
…ot-sdk into emit-events-currency
|
Review required! Latest push from author must always be reviewed |
Head branch was pushed to by a user without write access
|
Sorry for the inconvenience @bkchr 🥲 |
|
@bkchr Looks like there is an issue with the For the first one, there should be the EventRecord {
phase: Phase::ApplyExtrinsic(1),
event: RuntimeEvent::Balances(pallet_balances::Event::Rescinded {
amount: fees * 2 / 10,
}),
topics: vec![],
},For the second one, there would 9 events per signed extrinsic because of the extra assert_eq!(
kitchensink_runtime::System::events().len(),
(self.block.extrinsics.len() - 2) * 9 + 2,
);I would like to run these tests locally before pushing just to catch further errors. Is there a way to run them locally? Whenever I run |
|
@mittal-parth did you try to just compile Otherwise you maybe not have enough main memory? How much do you have? |
Tried this, same result :(
I have 20GB RAM and 8 GB swap space. |
|
Is your system freezing because it runs out of memory or what? |
|
/tip small |
|
@kianenigma A referendum for a small (20 DOT) tip was successfully submitted for @mittal-parth (5GsLutpKjbzsbTphebs9Uy4YK6gTN47MAaz6njPktidjR5cp on polkadot). |
|
The referendum has appeared on Polkassembly. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
…itytech#4936) # Description Previously, in the `Currency` impl, the implementation of `pallet_balances` was not emitting any instances of `Issued` and `Rescinded` events, even though the `Fungible` equivalent was. This PR adds the `Issued` and `Rescinded` events in appropriate places in `impl_currency` along with tests. Closes paritytech#4028 polkadot address: 5GsLutpKjbzsbTphebs9Uy4YK6gTN47MAaz6njPktidjR5cp --------- Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Bastian Köcher <info@kchr.de>

Description
Previously, in the
Currencyimpl, the implementation ofpallet_balanceswas not emitting any instances ofIssuedandRescindedevents, even though theFungibleequivalent was.This PR adds the
IssuedandRescindedevents in appropriate places inimpl_currencyalong with tests.Closes #4028
polkadot address: 5GsLutpKjbzsbTphebs9Uy4YK6gTN47MAaz6njPktidjR5cp