Do not make pallet-nfts benchmarks signature-dependent#4756
Merged
bkchr merged 8 commits intoparitytech:masterfrom Jun 21, 2024
Merged
Do not make pallet-nfts benchmarks signature-dependent#4756bkchr merged 8 commits intoparitytech:masterfrom
bkchr merged 8 commits intoparitytech:masterfrom
Conversation
ggwpez
approved these changes
Jun 11, 2024
bkchr
reviewed
Jun 17, 2024
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
polkadot-sdk/substrate/frame/nfts/src/benchmarking.rs
Lines 232 to 236 in ad86209
Comment on lines
+98
to
+100
| sp_runtime::MultiSigner, | ||
| sp_runtime::AccountId32, | ||
| sp_runtime::MultiSignature, |
Member
There was a problem hiding this comment.
Hmm. This is not a good solution. This way () will not work for any runtime.
Contributor
Author
There was a problem hiding this comment.
Current behaviour is that it builds but fails to execute the benchmarks. In my opinion it's already an improvement that it does not build, so that you can take care of the error instead of thinking "benchmarks will be fine because it compiles".
Contributor
Author
Nice catch. Done in 54b2397. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
bkchr
approved these changes
Jun 21, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
This PR: - Adds extra functionality to pallet-nfts's `BenchmarkHelper` to provide signers and sign message. - Abstracts away the explicit link with Sr25519 schema in the benchmarks, allowing parachains with a different one to be able to run them and calculate the weights. - Adds a default implementation for the empty tuple that leaves the code equivalent.
This was referenced Aug 21, 2024
sfffaaa
pushed a commit
to peaqnetwork/polkadot-sdk
that referenced
this pull request
Dec 27, 2024
This PR: - Adds extra functionality to pallet-nfts's `BenchmarkHelper` to provide signers and sign message. - Abstracts away the explicit link with Sr25519 schema in the benchmarks, allowing parachains with a different one to be able to run them and calculate the weights. - Adds a default implementation for the empty tuple that leaves the code equivalent.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2025
Similar to #4756 for `pallet-nfts`, the changes proposed in this PR intend to make benchmarks for `pallet-identity` signature-agnostic by the inclusion of a benchmark helper with sane defaults to handle the signing operations.
pgherveou
pushed a commit
that referenced
this pull request
Jun 11, 2025
Similar to #4756 for `pallet-nfts`, the changes proposed in this PR intend to make benchmarks for `pallet-identity` signature-agnostic by the inclusion of a benchmark helper with sane defaults to handle the signing operations.
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
Similar to #4756 for `pallet-nfts`, the changes proposed in this PR intend to make benchmarks for `pallet-identity` signature-agnostic by the inclusion of a benchmark helper with sane defaults to handle the signing operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
BenchmarkHelperto provide signers and sign message.