refactor: parachain template#4684
Conversation
| { | ||
| System: frame_system::{Pallet, Call, Config<T>, Storage, Event<T>}, | ||
| TemplateModule: crate::{Pallet, Call, Storage, Event<T>}, | ||
| pub enum Test { |
There was a problem hiding this comment.
| pub enum Test { | |
| pub struct Test { |
There was a problem hiding this comment.
@gupnik we can move all of this to the new syntax as well right?
There was a problem hiding this comment.
@gupnik we can move all of this to the new syntax as well right?
Yes! @Daanvdplas Do you want to give that a try? #1378 should help.
There was a problem hiding this comment.
Will finish this weekend
There was a problem hiding this comment.
It also compiled without experimental feature, didn't run a local network with it though, added it because I saw it being used in other places.
There was a problem hiding this comment.
Yeah, runtime macro is out of experimental now.
Daanvdplas
force-pushed
the
daan/refactor-parachain_template
branch
from
a642271 to
768af06
Compare
FYI, with Pop CLI we are working on a feature |
| # frame deps | ||
| frame-benchmarking = { path = "../../../../substrate/frame/benchmarking", default-features = false, optional = true } | ||
| frame-support = { path = "../../../../substrate/frame/support", default-features = false } | ||
| frame-support = { path = "../../../../substrate/frame/support", default-features = false, features = ["experimental"] } |
There was a problem hiding this comment.
We should not add experimental stuff to the template. The point of it being that it is still experimental and subject to change.
There was a problem hiding this comment.
So revert the changes regarding construct runtime v2? @gupnik
There was a problem hiding this comment.
So revert the changes regarding construct runtime v2? @gupnik
It's not experimental anymore. You should be able to use it without that flag @Daanvdplas.
There was a problem hiding this comment.
Then we should not enable the experimental feature :P
There was a problem hiding this comment.
Apologies, I thought seeing it being used in the kitchen sink runtime but I think I had a bad dream. Thanks Kian
|
Should be good to go now |
Update parachain template pallet based on polkadot sdk docs @kianenigma --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Update parachain template pallet based on polkadot sdk docs @kianenigma --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
5 participants
Update parachain template pallet based on polkadot sdk docs
@kianenigma