Skip to content

Backport broker new price adapter (#4521) without extra changes#4656

Merged
seadanda merged 3 commits intorelease-polkadot-v1.7.3from
broker-v0.7.3
Jun 3, 2024
Merged

Backport broker new price adapter (#4521) without extra changes#4656
seadanda merged 3 commits intorelease-polkadot-v1.7.3from
broker-v0.7.3

Conversation

@seadanda
Copy link
Copy Markdown
Contributor

Only the price adapter changes are backported to avoid out-of-order migrations

Only the price adapter changes are backported to avoid out-of-order migrations
@seadanda seadanda requested a review from a team as a code owner May 31, 2024 10:59
@seadanda seadanda added A3-backport Pull request is already reviewed well in another branch. T2-pallets This PR/Issue is related to a particular pallet. R0-no-crate-publish-required The change does not require any crates to be re-published. labels May 31, 2024
@paritytech-cicd-pr
Copy link
Copy Markdown

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6377840

@seadanda seadanda changed the base branch from release-polkadot-v1.7.2 to release-polkadot-v1.7.3 June 3, 2024 10:34
@seadanda seadanda merged commit 3bbbffa into release-polkadot-v1.7.3 Jun 3, 2024
@seadanda seadanda deleted the broker-v0.7.3 branch June 3, 2024 12:57
seadanda added a commit that referenced this pull request Jun 3, 2024
seadanda added a commit that referenced this pull request Jun 3, 2024
Only the price adapter changes are backported to avoid out-of-order
migrations
seadanda added a commit that referenced this pull request Jun 3, 2024
When merging the two backports (#4194 and #4656) for the broker pallet,
the priority of the changes seems to have been reversed and ended up
with some broken code.

CI doesn't actually run before merging on these release branches so it
merged with broken tests. `release-` branches are protected so it needs
this PR to remove the duplication. Sorry for the noise.
@seadanda seadanda mentioned this pull request Jun 4, 2024
EgorPopelyaev pushed a commit that referenced this pull request Jun 4, 2024
Related to #4521 and
#4656

This allows a release of the Broker pallet so the new price adapter can
be tested on Kusama ASAP
(polkadot-fellows/runtimes#334).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch. R0-no-crate-publish-required The change does not require any crates to be re-published. T2-pallets This PR/Issue is related to a particular pallet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants