Skip to content

Add Dockerfiles to the templates#4637

Merged
rzadp merged 1 commit intomasterfrom
rzadp/template-dockerfiles
Jun 3, 2024
Merged

Add Dockerfiles to the templates#4637
rzadp merged 1 commit intomasterfrom
rzadp/template-dockerfiles

Conversation

@rzadp
Copy link
Copy Markdown
Contributor

@rzadp rzadp commented May 29, 2024

As requested here.

The Dockerfiles are inspired by this one.

@rzadp rzadp added the R0-no-crate-publish-required The change does not require any crates to be re-published. label May 29, 2024
@rzadp rzadp requested review from gupnik and kianenigma May 29, 2024 19:52
@rzadp rzadp requested a review from a team May 30, 2024 09:55
@rzadp rzadp mentioned this pull request May 30, 2024
Merged
kianenigma
kianenigma reviewed May 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, is there a way to test these automatically?

@rzadp
Copy link
Copy Markdown
Contributor Author

rzadp commented May 31, 2024

great, is there a way to test these automatically?

I did a preview run of building this dockerfile on regular GitHub CI in the template repo - so we can have it running there, and it'll be useful for consumers of the template as well.

I'll be able to add this workflow to the templates only after the Dockerfile get synchronized there.

@rzadp rzadp requested a review from kianenigma June 3, 2024 08:11
@rzadp rzadp added this pull request to the merge queue Jun 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 3, 2024
@rzadp rzadp added this pull request to the merge queue Jun 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 3, 2024
@rzadp @nixdotbuild
Revamp the Readme of the minimal template (#4649)
dfb01aa 
- Addresses
[this](#3155 (comment)).
- Technical content got adopted from the existing [solochain
readme](https://github.com/paritytech/polkadot-sdk/tree/master/templates/solochain).
  - Updated some broken links there.
- The docker instructions will work after
#4637.
- See the [rendered
version](https://github.com/paritytech/polkadot-sdk/blob/rzadp/minimal-template-readme/templates/minimal/README.md).

---------

Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>
Merged via the queue into master with commit 6ede7a0 Jun 3, 2024
@rzadp rzadp deleted the rzadp/template-dockerfiles branch June 3, 2024 11:09
ordian added a commit that referenced this pull request Jun 4, 2024
@ordian
Merge branch 'master' into ao-fix-backing-filtering-on-disputes
e91b425 
* master: (106 commits)
  [ci] Delete unused flow (#4676)
  Fix umbrella CI check and fix the C&P message (#4670)
  Add Dockerfiles to the templates (#4637)
  Revamp the Readme of the minimal template (#4649)
  Add chain-spec-builder docker image (#4655)
  Update Amforc bootnodes for Kusama and Polkadot (#4668)
  make all storage items in parachain-system public (#4645)
  [Pools] Refactors and runtime apis for DelegateStake (#4537)
  update amforc westend and its parachain bootnodes (#4641)
  Better error for missing index in CRV2 (#4643)
  Implement `XcmPaymentApi` and `DryRunApi` on all system parachains (#4634)
  Use Unlicense for templates (#4628)
  collator-protocol: remove `elastic-scaling-experimental` feature (#4595)
  Update `runtime_type` ref doc with the new "Associated Type Bounds" (#4624)
  Adds ability to specify chain type in chain-spec-builder (#4542)
  Fix broken windows build (#4636)
  Beefy client generic on aduthority Id (#1816)
  pallet-staking: Put tests behind `cfg(debug_assertions)` (#4620)
  Broker new price adapter (#4521)
  Change `XcmDryRunApi::dry_run_extrinsic` to take a call instead (#4621)
  ...
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@rzadp @nixdotbuild @hitchhooker
Revamp the Readme of the minimal template (paritytech#4649)
f3c177a 
- Addresses
[this](paritytech#3155 (comment)).
- Technical content got adopted from the existing [solochain
readme](https://github.com/paritytech/polkadot-sdk/tree/master/templates/solochain).
  - Updated some broken links there.
- The docker instructions will work after
paritytech#4637.
- See the [rendered
version](https://github.com/paritytech/polkadot-sdk/blob/rzadp/minimal-template-readme/templates/minimal/README.md).

---------

Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@rzadp @hitchhooker
Add Dockerfiles to the templates (paritytech#4637)
3900554 
As requested
[here](paritytech#3155 (comment)).

The Dockerfiles are inspired by [this
one](https://github.com/paritytech/polkadot-sdk/blob/aa32faaebf64426becb2feeede347740eb7a3908/docker/dockerfiles/polkadot/polkadot_builder.Dockerfile).
@evilrobot-01
Copy link
Copy Markdown

evilrobot-01 commented Jun 26, 2024

FYI: I think the symlink is incorrect, gives me a permission denied when testing.

Correcting it to the binary name seems to resolve - e.g.
ln -s /data /polkadot/.local/share/parachain-template-node && \

@rzadp
Copy link
Copy Markdown
Contributor Author

rzadp commented Jul 1, 2024

Hey @evilrobot-01, the dockerfile is supposed to be built in the context of the separate template repository: https://github.com/paritytech/polkadot-sdk-minimal-template

Are you doing it this way?

The dockerfile is building correctly on CI: see this PR.

TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@rzadp @nixdotbuild @TarekkMA
Revamp the Readme of the minimal template (paritytech#4649)
9247ffa 
- Addresses
[this](paritytech#3155 (comment)).
- Technical content got adopted from the existing [solochain
readme](https://github.com/paritytech/polkadot-sdk/tree/master/templates/solochain).
  - Updated some broken links there.
- The docker instructions will work after
paritytech#4637.
- See the [rendered
version](https://github.com/paritytech/polkadot-sdk/blob/rzadp/minimal-template-readme/templates/minimal/README.md).

---------

Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@rzadp @TarekkMA
Add Dockerfiles to the templates (paritytech#4637)
52c4908 
As requested
[here](paritytech#3155 (comment)).

The Dockerfiles are inspired by [this
one](https://github.com/paritytech/polkadot-sdk/blob/aa32faaebf64426becb2feeede347740eb7a3908/docker/dockerfiles/polkadot/polkadot_builder.Dockerfile).
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
@rzadp @nixdotbuild
Revamp the Readme of the minimal template (paritytech#4649)
f5c08a3 
- Addresses
[this](paritytech#3155 (comment)).
- Technical content got adopted from the existing [solochain
readme](https://github.com/paritytech/polkadot-sdk/tree/master/templates/solochain).
  - Updated some broken links there.
- The docker instructions will work after
paritytech#4637.
- See the [rendered
version](https://github.com/paritytech/polkadot-sdk/blob/rzadp/minimal-template-readme/templates/minimal/README.md).

---------

Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
@rzadp
Add Dockerfiles to the templates (paritytech#4637)
ce29f06 
As requested
[here](paritytech#3155 (comment)).

The Dockerfiles are inspired by [this
one](https://github.com/paritytech/polkadot-sdk/blob/aa32faaebf64426becb2feeede347740eb7a3908/docker/dockerfiles/polkadot/polkadot_builder.Dockerfile).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kianenigma kianenigma kianenigma approved these changes

+1 more reviewer

@gupnik gupnik gupnik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rzadp @evilrobot-01 @kianenigma @gupnik