Skip to content

Use polkadot-ckb-merkle-mountain-range dependency#4562

Merged
serban300 merged 1 commit intoparitytech:masterfrom
serban300:mmr-release
May 24, 2024
Merged

Use polkadot-ckb-merkle-mountain-range dependency#4562
serban300 merged 1 commit intoparitytech:masterfrom
serban300:mmr-release

Conversation

@serban300
Copy link
Copy Markdown
Contributor

We need to use the polkadot-ckb-merkle-mountain-range dependency published on crates.io in order to unblock the release of the sp-mmr-primitives crate

@serban300 serban300 requested a review from svyatonik May 24, 2024 07:03
@serban300 serban300 self-assigned this May 24, 2024
@serban300 serban300 requested a review from acatangiu as a code owner May 24, 2024 07:03
@serban300 serban300 added R0-no-crate-publish-required The change does not require any crates to be re-published. T15-bridges This PR/Issue is related to bridges. labels May 24, 2024
@serban300 serban300 added this pull request to the merge queue May 24, 2024
Merged via the queue into paritytech:master with commit 700d591 May 24, 2024
@serban300 serban300 deleted the mmr-release branch May 24, 2024 08:07
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
We need to use the `polkadot-ckb-merkle-mountain-range` dependency
published on `crates.io` in order to unblock the release of the
`sp-mmr-primitives` crate
@FlorianFranzen
Copy link
Copy Markdown
Contributor

FlorianFranzen commented Jun 11, 2024

Please make sure to not pull from master when renaming things:

error: no matching package named `ckb-merkle-mountain-range` found
location searched: https://github.com/paritytech/merkle-mountain-range.git?branch=master
required by package `sp-mmr-primitives v26.0.0 (https://github.com/paritytech/polkadot-sdk?tag=polkadot-v1.12.0#b4016902)`
    ... which satisfies git dependency `sp-mmr-primitives` of package `sp-consensus-beefy v13.0.0 (https://github.com/paritytech/polkadot-sdk?tag=polkadot-v1.12.0#b4016902)`
    ... which satisfies git dependency `sp-consensus-beefy` of package `timechain-node v0.5.0 (/home/florian/Analog/timechain/node)`

This now lead to the latest release v1.12.0 of the SDK not building if no lock was present or one tried to update.

@ggwpez
Copy link
Copy Markdown
Member

ggwpez commented Jun 11, 2024

Using git dependencies is the general issue. We removed this one now, but looks like it is still present in the 1.12 release.
But yea, having master instead of a commit hash makes it easier to error here.

TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
We need to use the `polkadot-ckb-merkle-mountain-range` dependency
published on `crates.io` in order to unblock the release of the
`sp-mmr-primitives` crate
acatangiu pushed a commit that referenced this pull request Oct 7, 2024
…#5897)

# Description

Polkadot SDK v1.12.0 `mmr-lib` dependency of the `sp-mmr-primitives`
crate is set to the package `ckb-merkle-mountain-range` and pinned to
the master branch of
[this](https://github.com/paritytech/merkle-mountain-range) repo. The
package name in that branch has changed to
`polkadot-ckb-merkle-mountain-range`, which causes v1.12.0 to not
compile.

This PR does a simple backport to utilize the
`polkadot-ckb-merkle-mountain-range` published package instead, and pins
it to version 0.7.0, as was done in #4562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T15-bridges This PR/Issue is related to bridges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants