Skip to content

Fix extrinsics count logging in frame-system #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkchr merged 3 commits into from
May 15, 2024
Merged

Fix extrinsics count logging in frame-system #4461

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7173d03
Fix extrinsics count logging in frame-system
liuchengxu May 15, 2024
02841a4
Add prdoc
liuchengxu May 15, 2024
fabc274
Update prdoc/pr_4461.prdoc
bkchr May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions prdoc/pr_4461.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
title: Fix extrinsics count logging in frame-system

doc:
- audience: Runtime Dev
description: |
Fixes the issue of the number of extrinsics in the block always being 0 in the log of frame-system.

crates:
- name: frame-system
Comment thread
bkchr marked this conversation as resolved.
2 changes: 1 addition & 1 deletion substrate/frame/system/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1780,7 +1780,7 @@ impl<T: Config> Pallet<T> {
"[{:?}] {} extrinsics, length: {} (normal {}%, op: {}%, mandatory {}%) / normal weight:\
{} ({}%) op weight {} ({}%) / mandatory weight {} ({}%)",
Self::block_number(),
Self::extrinsic_index().unwrap_or_default(),
Self::extrinsic_count(),
Self::all_extrinsics_len(),
sp_runtime::Percent::from_rational(
Self::all_extrinsics_len(),
Expand Down