Skip to content

Rococo AH: cleanup storage#4444

Merged
acatangiu merged 3 commits intomasterfrom
oty-remove-pallet
Jun 5, 2024
Merged

Rococo AH: cleanup storage#4444
acatangiu merged 3 commits intomasterfrom
oty-remove-pallet

Conversation

@ggwpez
Copy link
Copy Markdown
Member

@ggwpez ggwpez commented May 13, 2024

Follow up on #4414 to clean up the old storage.

ggwpez added 2 commits May 13, 2024 12:42
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez added the T14-system_parachains This PR/Issue is related to system parachains. label May 13, 2024
Copy link
Copy Markdown
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ignored this on purpose, because these chains are going to stop in the hopefully near future any way :D

@kianenigma
Copy link
Copy Markdown
Contributor

How about a

pub struct DetectDanglingStorage<Exceptions: Get<Vec<u8>>>;
impl OnRuntimeUpgrade for DetectDanglingStorage {
  fn on_runtime_upgrade() { noop } 
  fn post_update() { 
    // iterate over all keys, match them to pallet storage from metadata
    // using the same tools that make `DecodeEntireState`
    // detect all keys that have value and
    // 1. not part of any pallet
    // 2. not part of `Exceptions`
  }

@ggwpez
Copy link
Copy Markdown
Member Author

ggwpez commented May 13, 2024

Yea ^ that sounds pretty nice.

@acatangiu acatangiu enabled auto-merge June 5, 2024 13:32
@acatangiu acatangiu added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit d129968 Jun 5, 2024
@acatangiu acatangiu deleted the oty-remove-pallet branch June 5, 2024 14:26
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Follow up on paritytech#4414 to clean up the old storage.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
sfffaaa pushed a commit to peaqnetwork/polkadot-sdk that referenced this pull request Dec 27, 2024
Follow up on paritytech#4414 to clean up the old storage.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T14-system_parachains This PR/Issue is related to system parachains.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants