fix(chain-spec): ChainSpecBuilder with object as default genesis#4345
Merged
bkchr merged 3 commits intoparitytech:masterfrom Jul 24, 2024
Merged
fix(chain-spec): ChainSpecBuilder with object as default genesis#4345bkchr merged 3 commits intoparitytech:masterfrom
bkchr merged 3 commits intoparitytech:masterfrom
Conversation
…nesis The current `json_patch::merge` function will replace the default configuration with the builder action if the action is not a JSON Object, which means, if not configured, the current code will try to use `Value::Null` as the config, which (almost?) always fails, making it mandatory to configure `with_genesis_config...`. This change uses a JSON Object as the default values, which means the code will continue using the default config if none is given.
|
User @saiintbrisson, please sign the CLA here. |
bkchr
approved these changes
May 2, 2024
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Could you please add some test and some comment?
lexnv
approved these changes
May 2, 2024
michalkucharczyk
approved these changes
May 2, 2024
bkchr
added
R0-no-crate-publish-required
bkchr
added
T0-node
bkchr
added
R0-no-crate-publish-required
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…itytech#4345) The current `json_patch::merge` function will replace the default configuration with the builder action if the action is not a JSON Object, which means, if not configured, the current code will try to use `Value::Null` as the config, which (almost?) always fails, making it mandatory to configure `with_genesis_config...`. This change uses a JSON Object as the default values, which means the code will continue using the default config if none is given. Co-authored-by: Bastian Köcher <[email protected]>
ordian
added a commit
that referenced
this pull request
Aug 6, 2024
* master: (27 commits) Bridges improved tests and nits (#5128) Fix misleading comment about RewardHandler in epm config (#3095) Introduce a workflow updating the wishlist leaderboards (#5085) membership: Restructure pallet into separate files (#4536) Fix after ring-proof api change (#5126) Bump paritytech/review-bot from 2.4.0 to 2.5.0 (#5057) Bump docker/login-action from 3.0.0 to 3.3.0 (#5109) Bump docker/build-push-action from 5.1.0 to 6.5.0 (#5108) Bump peter-evans/create-pull-request from 5.0.0 to 6.1.0 (#5093) Tx Payment: drop ED requirements for tx payments with exchangeable asset (#4488) Remove `pallet-getter` usage from pallet-transaction-payment (#4970) pallet macro: do not generate try-runtime related code when frame-support doesn't have try-runtime. (#5099) fix(chain-spec): ChainSpecBuilder with object as default genesis (#4345) Migrate BEEFY BLS crypto to bls12-381 curve (#4931) Bump clap from 4.5.9 to 4.5.10 in the known_good_semver group (#5120) Use jobserver in wasm-builder to limit concurrency of spawned cargo processes (#4946) include events for voting (#4613) [subsystem-bench] Add mocks for own assignments triggering (#5042) Remove not-audited warning (#5114) hotfix: blockchain/backend: Skip genesis leaf to unblock syncing (#5103) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
json_patch::mergefunction will replace the default configuration with the builder action if the action is not a JSON Object, which means, if not configured, the current code will try to useValue::Nullas the config, which (almost?) always fails, making it mandatory to configurewith_genesis_config....This change uses a JSON Object as the default values, which means the code will continue using the default config if none is given.