[dnm-testing] litep2p/experimental: Enable WebRTC#4310
Closed
Conversation
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv
changed the title
This was referenced May 1, 2024
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
dmitry-markin
approved these changes
May 10, 2024
Member
|
@lexnv will you still merge this? |
Contributor
Author
|
We've had some issues with connecting to smoldot. Will close this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the litep2p WebRTC transport layer that was recently merged to the litep2p crate, thanks to @altonen and @dmitry-markin for the huge heavy lifting there!
This PR relies on a branch of litep2p, which we hope soon to merge. The branch updates the interval str0m crate to the latest version, which contains among other bug fixes a fix to increment the channel ID of webRTC connections.
Please note that webRTC is still an unstable feature and other problems may appear during testing.
It would be of great help to our efforts to stabilize this to report back any issues to https://github.com/paritytech/litep2p.
To check this functionality, use the following to enable litep2p
--network-backend litep2pcc @paritytech/networking