Skip to content

txWatch: Stabilize txWatch to version 1 #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexnv merged 6 commits into from
Apr 19, 2024
Merged

txWatch: Stabilize txWatch to version 1 #4171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
62018cc
txWatch: Stabilize txWatch to version 1
lexnv Apr 17, 2024
6ea5bdf
prdoc: Add prdoc
lexnv Apr 17, 2024
102af2b
Merge branch 'master' into lexnv/txwatch-bv1
lexnv Apr 18, 2024
1fa2197
Merge branch 'master' into lexnv/txwatch-bv1
lexnv Apr 18, 2024
80f1366
Merge branch 'master' into lexnv/txwatch-bv1
lexnv Apr 19, 2024
4cd14be
Merge branch 'master' into lexnv/txwatch-bv1
lexnv Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions prdoc/pr_4171.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
title: Stabilize transactionWatch RPC class to version 1

doc:
- audience: Node Dev
description: |
The transactionWatch RPC API is stabilized to version 1.

crates: [ ]
4 changes: 2 additions & 2 deletions substrate/client/rpc-spec-v2/src/transaction/api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ pub trait TransactionApi<Hash: Clone> {
///
/// This method is unstable and subject to change in the future.
#[subscription(
name = "transactionWatch_unstable_submitAndWatch" => "transactionWatch_unstable_watchEvent",
unsubscribe = "transactionWatch_unstable_unwatch",
name = "transactionWatch_v1_submitAndWatch" => "transactionWatch_v1_watchEvent",
unsubscribe = "transactionWatch_v1_unwatch",
item = TransactionEvent<Hash>,
)]
fn submit_and_watch(&self, bytes: Bytes);
Expand Down
6 changes: 3 additions & 3 deletions substrate/client/rpc-spec-v2/src/transaction/tests/transaction_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ async fn tx_invalid_bytes() {

// This should not rely on the tx pool state.
let mut sub = tx_api
.subscribe_unbounded("transactionWatch_unstable_submitAndWatch", rpc_params![&"0xdeadbeef"])
.subscribe_unbounded("transactionWatch_v1_submitAndWatch", rpc_params![&"0xdeadbeef"])
.await
.unwrap();

Expand All @@ -56,7 +56,7 @@ async fn tx_in_finalized() {
let xt = hex_string(&uxt.encode());

let mut sub = tx_api
.subscribe_unbounded("transactionWatch_unstable_submitAndWatch", rpc_params![&xt])
.subscribe_unbounded("transactionWatch_v1_submitAndWatch", rpc_params![&xt])
.await
.unwrap();

Expand Down Expand Up @@ -95,7 +95,7 @@ async fn tx_with_pruned_best_block() {
let xt = hex_string(&uxt.encode());

let mut sub = tx_api
.subscribe_unbounded("transactionWatch_unstable_submitAndWatch", rpc_params![&xt])
.subscribe_unbounded("transactionWatch_v1_submitAndWatch", rpc_params![&xt])
.await
.unwrap();

Expand Down