Pallet assets: new status LiveAndNoPrivilege and new call revoke_all_privilege

cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-rococo/src/tests/burn_at_relay.rs

@@ -0,0 +1,84 @@
+// Copyright (C) Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: Apache-2.0
+
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// 	http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use crate::imports::*;
+use emulated_integration_tests_common::accounts;
+
+/// Create asset and then remove privileges; this results in the burning of the deposit, which must
+/// burn at the Relay Chain.
+#[test]
+fn create_asset_remove_privileges_burn_deposit_at_relay() {
+	let owner = AssetHubRococo::account_id_of(accounts::CHARLIE);
+	let asset_id = 3939;
+
+	// We need first to teleport some balance so that it can be withdrawn later on the Relay
+	// Chain. Otherwise the asset is not withdrawable due to how genesis is set up.
+	Rococo::execute_with(|| {
+		type XcmPallet = <Rococo as RococoPallet>::XcmPallet;
+
+		assert_ok!(XcmPallet::limited_teleport_assets(
+			<Rococo as Chain>::RuntimeOrigin::signed(Rococo::account_id_of(accounts::CHARLIE)),
+			bx!(Parachain(AssetHubRococo::para_id().into()).into()),
+			bx!((*AsRef::<[u8; 32]>::as_ref(&owner)).into()),
+			bx!(Assets::from((Here, 1_000_000_000_000u128)).into()),
+			0,
+			WeightLimit::Unlimited,
+		));
+	});
+
+	let original_total_issuance =
+		Rococo::execute_with(|| <Rococo as RococoPallet>::Balances::total_issuance());
+
+	let deposit = AssetHubRococo::execute_with(|| {
+		type Assets = <AssetHubRococo as AssetHubRococoPallet>::Assets;
+		type Balances = <AssetHubRococo as AssetHubRococoPallet>::Balances;
+
+		let original_reserved_balance = Balances::reserved_balance(owner.clone());
+
+		assert_ok!(Assets::create(
+			<AssetHubRococo as Chain>::RuntimeOrigin::signed(owner.clone()),
+			asset_id.into(),
+			owner.clone().into(),
+			1,
+		));
+		assert_ok!(Assets::set_metadata(
+			<AssetHubRococo as Chain>::RuntimeOrigin::signed(owner.clone()),
+			asset_id.into(),
+			vec![],
+			vec![],
+			0,
+		));
+
+		let new_reserved_balance = Balances::reserved_balance(owner.clone());
+		let original_total_issuance = Balances::total_issuance();
+
+		let deposit = new_reserved_balance - original_reserved_balance;
+		assert!(deposit != 0); // This ensures we are testing something.
+
+		assert_ok!(Assets::revoke_all_privileges(
+			<AssetHubRococo as Chain>::RuntimeOrigin::signed(owner.clone()),
+			asset_id.into(),
+		));
+
+		assert_eq!(deposit, original_total_issuance - Balances::total_issuance());
+
+		deposit
+	});
+
+	let new_total_issuance =
+		Rococo::execute_with(|| <Rococo as RococoPallet>::Balances::total_issuance());
+
+	assert_eq!(deposit, original_total_issuance - new_total_issuance);
+}

cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-rococo/src/tests/mod.rs

@@ -13,6 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+mod burn_at_relay;
 mod claim_assets;
 mod hybrid_transfers;
 mod reserve_transfer;

cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-westend/src/tests/burn_at_relay.rs

@@ -0,0 +1,84 @@
+// Copyright (C) Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: Apache-2.0
+
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// 	http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use crate::imports::*;
+use emulated_integration_tests_common::accounts;
+
+/// Create asset and then remove privileges; this results in the burning of the deposit, which must
+/// burn at the Relay Chain.
+#[test]
+fn create_asset_remove_privileges_burn_deposit_at_relay() {
+	let owner = AssetHubWestend::account_id_of(accounts::CHARLIE);
+	let asset_id = 3939;
+
+	// We need first to teleport some balance so that it can be withdrawn later on the Relay
+	// Chain. Otherwise the asset is not withdrawable due to how genesis is set up.
+	Westend::execute_with(|| {
+		type XcmPallet = <Westend as WestendPallet>::XcmPallet;
+
+		assert_ok!(XcmPallet::limited_teleport_assets(
+			<Westend as Chain>::RuntimeOrigin::signed(Westend::account_id_of(accounts::CHARLIE)),
+			bx!(Parachain(AssetHubWestend::para_id().into()).into()),
+			bx!((*AsRef::<[u8; 32]>::as_ref(&owner)).into()),
+			bx!(Assets::from((Here, 1_000_000_000_000u128)).into()),
+			0,
+			WeightLimit::Unlimited,
+		));
+	});
+
+	let original_total_issuance =
+		Westend::execute_with(|| <Westend as WestendPallet>::Balances::total_issuance());
+
+	let deposit = AssetHubWestend::execute_with(|| {
+		type Assets = <AssetHubWestend as AssetHubWestendPallet>::Assets;
+		type Balances = <AssetHubWestend as AssetHubWestendPallet>::Balances;
+
+		let original_reserved_balance = Balances::reserved_balance(owner.clone());
+
+		assert_ok!(Assets::create(
+			<AssetHubWestend as Chain>::RuntimeOrigin::signed(owner.clone()),
+			asset_id.into(),
+			owner.clone().into(),
+			1,
+		));
+		assert_ok!(Assets::set_metadata(
+			<AssetHubWestend as Chain>::RuntimeOrigin::signed(owner.clone()),
+			asset_id.into(),
+			vec![],
+			vec![],
+			0,
+		));
+
+		let new_reserved_balance = Balances::reserved_balance(owner.clone());
+		let original_total_issuance = Balances::total_issuance();
+
+		let deposit = new_reserved_balance - original_reserved_balance;
+		assert!(deposit != 0); // This ensures we are testing something.
+
+		assert_ok!(Assets::revoke_all_privileges(
+			<AssetHubWestend as Chain>::RuntimeOrigin::signed(owner.clone()),
+			asset_id.into(),
+		));
+
+		assert_eq!(deposit, original_total_issuance - Balances::total_issuance());
+
+		deposit
+	});
+
+	let new_total_issuance =
+		Westend::execute_with(|| <Westend as WestendPallet>::Balances::total_issuance());
+
+	assert_eq!(deposit, original_total_issuance - new_total_issuance);
+}

cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-westend/src/tests/mod.rs

@@ -13,6 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+mod burn_at_relay;
 mod claim_assets;
 mod fellowship_treasury;
 mod hybrid_transfers;

cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs

@@ -63,7 +63,8 @@ use frame_support::{
 	ord_parameter_types, parameter_types,
 	traits::{
 		fungible, fungibles, tokens::imbalance::ResolveAssetTo, AsEnsureOriginWithArg, ConstBool,
-		ConstU128, ConstU32, ConstU64, ConstU8, EitherOfDiverse, InstanceFilter, TransformOrigin,
+		ConstU128, ConstU32, ConstU64, ConstU8, DefensiveResult, EitherOfDiverse, Imbalance,
+		InstanceFilter, OnUnbalanced, TransformOrigin,
 	},
 	weights::{ConstantMultiplier, Weight, WeightToFee as _},
 	BoundedVec, PalletId,
@@ -99,13 +100,17 @@ use pallet_xcm::{EnsureXcm, IsVoiceOfBody};
 use polkadot_runtime_common::{BlockHashCount, SlowAdjustingFeeUpdate};
 #[cfg(feature = "runtime-benchmarks")]
 use xcm::latest::prelude::{
-	Asset, Assets as XcmAssets, Fungible, Here, InteriorLocation, Junction, Junction::*, Location,
-	NetworkId, NonFungible, Parent, ParentThen, Response, XCM_VERSION,
+	InteriorLocation, Junction, Junction::*, NetworkId, NonFungible, Parent, ParentThen, Response,
+	XCM_VERSION,
 };
 use xcm::{
-	latest::prelude::{AssetId, BodyId},
+	latest::prelude::{
+		Asset, AssetId, Assets as XcmAssets, BodyId, BurnAsset, Fungible, Here, Instruction,
+		Location, Reanchorable, ReceiveTeleportedAsset, WeightLimit, Xcm, XcmContext, XcmError,
+	},
 	VersionedAssetId, VersionedAssets, VersionedLocation, VersionedXcm,
 };
+use xcm_executor::traits::TransactAsset;
 use xcm_runtime_apis::{
 	dry_run::{CallDryRunEffects, Error as XcmDryRunApiError, XcmDryRunEffects},
 	fees::Error as XcmPaymentApiError,
@@ -245,6 +250,50 @@ parameter_types! {
 /// We allow root to execute privileged asset operations.
 pub type AssetsForceOrigin = EnsureRoot<AccountId>;
 
+type AssetTransactor = <xcm_config::XcmConfig as xcm_executor::Config>::AssetTransactor;
+
+fn try_burn_at_relay(value: Balance) -> Result<(), XcmError> {
+	let asset = Asset { id: AssetId(Location::parent()), fun: Fungible(value) };
+	let dest = Location::parent();
+	let parent_assets = Into::<XcmAssets>::into(asset.clone())
+		.reanchored(&dest, &Here.into())
+		.defensive_map_err(|_| XcmError::ReanchorFailed)?;
+
+	let dummy_xcm_context = XcmContext { origin: None, message_id: [0; 32], topic: None };
+
+	AssetTransactor::can_check_out(&dest, &asset, &dummy_xcm_context)?;
+
+	PolkadotXcm::send_xcm(
+		Here,
+		Location::parent(),
+		Xcm(vec![
+			Instruction::UnpaidExecution {
+				weight_limit: WeightLimit::Unlimited,
+				check_origin: None,
+			},
+			ReceiveTeleportedAsset(parent_assets.clone()),
+			BurnAsset(parent_assets),
+		]),
+	)?;
+
+	AssetTransactor::check_out(&dest, &asset, &dummy_xcm_context);
+
+	Ok(())
+}
+
+// Burn negative imbalance at the relay chain.
+pub struct BurnAtRelay;
+
+impl OnUnbalanced<pallet_balances::NegativeImbalance<Runtime>> for BurnAtRelay {
+	fn on_nonzero_unbalanced(amount: pallet_balances::NegativeImbalance<Runtime>) {
+		let amount = amount.peek();
+		if let Err(e) = try_burn_at_relay(amount) {
+			log::error!(target: "runtime::assets", "failed to burn balance at relay: amount: \
+				{amount}: {e:?}");
+		}
+	}
+}
+
 // Called "Trust Backed" assets because these are generally registered by some account, and users of
 // the asset assume it has some claimed backing. The pallet is called `Assets` in
 // `construct_runtime` to avoid breaking changes on storage reads.
@@ -269,6 +318,7 @@ impl pallet_assets::Config<TrustBackedAssetsInstance> for Runtime {
 	type CallbackHandle = ();
 	type AssetAccountDeposit = AssetAccountDeposit;
 	type RemoveItemsLimit = frame_support::traits::ConstU32<1000>;
+	type DepositDestinationOnRevocation = BurnAtRelay;
 	#[cfg(feature = "runtime-benchmarks")]
 	type BenchmarkHelper = ();
 }
@@ -312,6 +362,7 @@ impl pallet_assets::Config<PoolAssetsInstance> for Runtime {
 	type Extra = ();
 	type WeightInfo = weights::pallet_assets_pool::WeightInfo<Runtime>;
 	type CallbackHandle = ();
+	type DepositDestinationOnRevocation = BurnAtRelay;
 	#[cfg(feature = "runtime-benchmarks")]
 	type BenchmarkHelper = ();
 }
@@ -437,6 +488,7 @@ impl pallet_assets::Config<ForeignAssetsInstance> for Runtime {
 	type CallbackHandle = ();
 	type AssetAccountDeposit = ForeignAssetsAssetAccountDeposit;
 	type RemoveItemsLimit = frame_support::traits::ConstU32<1000>;
+	type DepositDestinationOnRevocation = BurnAtRelay;
 	#[cfg(feature = "runtime-benchmarks")]
 	type BenchmarkHelper = xcm_config::XcmBenchmarkHelper;
 }
@@ -1016,9 +1068,13 @@ pub type Migrations = (
 	InitStorageVersions,
 	// unreleased
 	cumulus_pallet_xcmp_queue::migration::v4::MigrationToV4<Runtime>,
+	// unreleased
 	cumulus_pallet_xcmp_queue::migration::v5::MigrateV4ToV5<Runtime>,
 	pallet_collator_selection::migration::v2::MigrationToV2<Runtime>,
 	frame_support::migrations::RemovePallet<StateTrieMigrationName, RocksDbWeight>,
+	pallet_assets::migration::v2::MigrateV1ToV2<Runtime, TrustBackedAssetsInstance>,
+	pallet_assets::migration::v2::MigrateV1ToV2<Runtime, PoolAssetsInstance>,
+	pallet_assets::migration::v2::MigrateV1ToV2<Runtime, ForeignAssetsInstance>,
 	// permanent
 	pallet_xcm::migration::MigrateToLatestXcmVersion<Runtime>,
 );