FRAME: Meta Transaction (pallet based version) by muharem · Pull Request #4122 · paritytech/polkadot-sdk

muharem · 2024-04-15T09:26:42Z

Meta transaction implementation based on a pallet's call and configurable via transaction extensions.

To see an example, refer to the sign_and_execute_meta_tx test case in substrate/frame/meta-tx/src/tests.rs file.

This implementation serves to demonstrate the concept and not production ready.

Based on: #3685
RFC: #4123
Alternative solution: #3712

TODOs:

benchmarks
more tests

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

… for `SignedExtension` (#2280)" (#3665)" This reverts commit bbd51ce.

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

…tx-ext

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

…tx-ext Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

…tx-ext

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

muharem · 2024-04-15T09:32:18Z

substrate/frame/meta-tx/src/lib.rs

+			// TODO: to get the len we have to encode the original `meta_tx`.
+			let len = 0;
+			let mut ctx = T::TxContext::default();
+


we can use set the DispatchTransaction bound for Config::TxExtension and use it's impl for everything below. here, for the demonstration purpose, I'm not utilizing it.

DispatchTransaction is meant to work only for "legacy" extensions which use a () context. I believe the current impl is the right thing 👍 .

kianenigma · 2024-04-15T14:17:28Z

substrate/frame/meta-tx/Cargo.toml

@@ -0,0 +1,53 @@
+[package]


This whole crate is great, and should live in frame/examples if it remains in any form.

kianenigma · 2024-04-15T14:21:12Z

substrate/frame/meta-tx/src/lib.rs

+		/// Signature type for meta transactions.
+		type Signature: Parameter + Verify<Signer = Self::PublicKey>;
+		/// Public key type used for signature verification.
+		type PublicKey: IdentifyAccount<AccountId = Self::AccountId>;


unrelated to this PR: Kind of a pitty that we can't fetch PublicKey and Signature from AccountId. The reverse is possible. You can always go from Signature (eg. MultiSignature) to PublicKey and then AccountId via IdentifyAccount.

in this scope I do not even need a public key type, but have no other way to ensure the signature type implemented over the account id the system operates with.

georgepisaltu

Looks great 👍

georgepisaltu · 2024-04-23T16:49:41Z

substrate/frame/meta-tx/src/lib.rs

+// TODO: The `MetaTx` type is similar to `sp_runtime::generic::UncheckedExtrinsic`. However,
+// `MetaTx` cannot replace generic::UncheckedExtrinsic because we need to box the call type,
+// given that `MetaTx` is used as an argument type for a call.


We could probably have this "destructured" in the extrinsic argument list if it looks funny because of the UncheckedExtrinsic similarity. I think it's fine.

georgepisaltu · 2024-04-23T16:52:11Z

substrate/frame/meta-tx/src/lib.rs

+pub enum Proof<Address, Signature> {
+	Signed(Address, Signature),
+	// TODO `General` as in `sp_runtime::generic::Preamble`.
+}


I think we can branch off the UncheckedExtrinsic and Preamble logic a bit here and consider introducing a variant for any type of custom validation logic supported by the pallet. In TransactionExtensions, they would be individual extensions in the pipeline, one for each validation type, each wrapping a General transaction.

Here, we care only about the call and validation type, which is nice.

georgepisaltu · 2024-04-23T16:53:37Z

substrate/frame/meta-tx/src/lib.rs

+			// TODO: to get the len we have to encode the original `meta_tx`.
+			let len = 0;
+			let mut ctx = T::TxContext::default();
+


DispatchTransaction is meant to work only for "legacy" extensions which use a () context. I believe the current impl is the right thing 👍 .

georgepisaltu · 2024-04-23T16:56:09Z

substrate/frame/meta-tx/src/lib.rs

+			let post_info = res.unwrap_or_else(|err| err.post_info);
+			let pd_res = res.map(|_| ()).map_err(|e| e.error);
+
+			T::TxExtension::post_dispatch(pre, &info, &post_info, len, &pd_res, &ctx)


This would allow a graceful and harmless failure in cases like the one described here when a post_dispatch fail is critical.

georgepisaltu · 2024-04-23T16:59:26Z

substrate/frame/meta-tx/src/lib.rs

+pub struct MetaTx<Address, Signature, Call, TxExtension> {
+	proof: Proof<Address, Signature>,
+	call: Box<Call>,
+	tx_ext: TxExtension,


Is there any reason why we can't get away with just a CheckNonce here? The other stuff will be checked when the agent submits the tx anyway, we just want the replay protection for Alice.

If we want to move off the extension approach completely, we could do the nonce check and inc without the extension even, just run the frame_system::Account mutation inside the extrinsic, but the signed payload would need to include the nonce. Maybe it's too complicated, just a thought.

paritytech-cicd-pr · 2024-05-07T15:34:54Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6152091

muharem · 2024-05-07T15:38:23Z

Clippy CI check fails on the file that is not edited by this PR. I will wait for the #3685 to be updated from master, to update this branch, which should address the issue.

Currently version of this branch compiles, tests pass.

jasl · 2024-10-27T16:48:54Z

Kindly ping.
Since Token Extension has merged, can it push Meta Transaction forward?

muharem · 2024-10-28T11:54:45Z

@jasl I am working on it

muharem · 2024-11-10T18:45:34Z

in favor of #6428

georgepisaltu and others added 20 commits March 8, 2024 13:29

Fixes and refactoring after tx ext introduction

e7c6f57

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Remove bench helper trait from claims

2fa52c8

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Rename additional_signed to implicit in IR

90819a5

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Fix imports

9206bea

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Fix metadata test

611c165

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Fix unchecked extrinsic signing in tests

6fd6b25

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Revert "Revert "FRAME: Create TransactionExtension as a replacement…

53c0379

… for `SignedExtension` (#2280)" (#3665)" This reverts commit bbd51ce.

Merge branch 'tx-ext-fixes' into george-tx-ext

ed40294

Add docs for impl_tx_ext_default

b6fba4a

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Remove TransactionExtensionInterior

455b762

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Merge remote-tracking branch 'origin/master' into george/restore-gav-…

5f6f63b

…tx-ext

Minor fixes for TransactionExtensionInterior

a896a50

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Fix metadata test

26ea26f

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Bump tx version in bridges

cde2b1e

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Missed file in previous commit

4c6f654

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Merge remote-tracking branch 'origin' into george/restore-gav-tx-ext

c4b522b

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Merge remote-tracking branch 'origin/master' into george/restore-gav-…

fabd306

…tx-ext Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

Merge remote-tracking branch 'origin/master' into george/restore-gav-…

ea5c623

…tx-ext

Run zepter

c67cff2

Signed-off-by: georgepisaltu <george.pisaltu@parity.io>

meta tx pallet gen

0699023

muharem commented Apr 15, 2024

View reviewed changes

muharem mentioned this pull request Apr 15, 2024

RFC: Meta Transaction Implementation #4123

Open

kianenigma reviewed Apr 15, 2024

View reviewed changes

This was referenced Apr 17, 2024

CheckNonce should not enforce the account creation requirement for feeless calls #3991

Open

Fixes nonce issue with feeless calls #4165

Open

georgepisaltu reviewed Apr 23, 2024

View reviewed changes

muharem added 3 commits May 7, 2024 16:08

resolve todos and docs

4e0fa2d

fix

7a104ef

include meta-tx instance into kitchensink runtime

59a66fa

muharem added 2 commits May 7, 2024 17:25

clippy fixes

ec0d668

remove unnecessary fmt

8407cd0

muharem added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label May 7, 2024

muharem marked this pull request as ready for review May 7, 2024 15:56

muharem requested a review from a team as a code owner May 7, 2024 15:56

georgepisaltu mentioned this pull request May 17, 2024

FRAME: Enable Meta Transaction for nonexistent accounts #4511

Draft

amarsinghcodes mentioned this pull request May 20, 2024

🎁 [Feature Request]: Account Abstraction for EVM template OpenZeppelin/polkadot-runtime-templates#199

Closed

1 task

balqaasem mentioned this pull request Jul 28, 2024

Account Abstraction and Meta Transactions setheum/setheum#1065

Open

Base automatically changed from george/restore-gav-tx-ext to master October 18, 2024 18:29

github-actions bot requested review from a team, acatangiu and cheme as code owners October 18, 2024 18:29

Merge remote-tracking branch 'origin/master' into muharem-meta-tx-pallet

6bf6b24

paritytech-review-bot bot requested a review from a team October 23, 2024 11:30

muharem closed this Nov 10, 2024

Conversation

muharem commented Apr 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

georgepisaltu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paritytech-cicd-pr commented May 7, 2024

Uh oh!

muharem commented May 7, 2024

Uh oh!

jasl commented Oct 27, 2024

Uh oh!

muharem commented Oct 28, 2024

Uh oh!

muharem commented Nov 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

muharem commented Apr 15, 2024 •

edited

Loading