You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The plain people-kusama and coretime-kusama chainspecs were uploaded at #3961. Only binaries with compatible runtime versions can run with plain chainspec. For example:
One of the latest master builds fails:
docker run paritypr/polkadot-parachain-debug:master-216509db --chain coretime-kusama
...
Error: Service(Client(Storage("wasm call error Other: Exported method GenesisBuilder_get_preset is not found"))
Master build from 5 days ago:
docker run paritypr/polkadot-parachain-debug:master-68cdb126 --chain coretime-kusama
...
2024-04-08 16:51:02 [Parachain] 🔨 Initializing Genesis block/state (state: 0xc418…889c, header-hash: 0x638c…d050)
2024-04-08 16:51:03 [Relaychain] 🔨 Initializing Genesis block/state (state: 0xb000…ef6b, header-hash: 0xb0a8…dafe)
2024-04-08 16:51:03 [Relaychain] 👴 Loading GRANDPA authority set from genesis on what appears to be first startup.
2024-04-08 16:51:03 [Relaychain] 👶 Creating empty BABE epoch changes on what appears to be first startup.
2024-04-08 16:51:03 [Relaychain] 🏷 Local node identity is: 12D3KooWQEp2uPow3FnngGmy9dYQ3qxY1GkmumS5MqBWEQscwTyy
2024-04-08 16:51:03 [Relaychain] 📦 Highest known block at #0
...
Ahh, I didn't pay too much attention to this. @michalkucharczyk your changes to the GenesisBuilder should have bumped the version of the runtime api trait and then you should have handled this gracefully. Aka check which runtime api version is present and then call the correct method.
Converting the chain specs here to raw is probably the easiest and best way forward, but we should prevent further breaking changes in the future.
bkchr
removed
A1-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
I4-refactor
Code needs refactoring.
D0-easy
Can be fixed primarily by duplicating and adapting code by an intermediate coder.
labels
Apr 9, 2024
Ahh, I didn't pay too much attention to this. @michalkucharczyk your changes to the GenesisBuilder should have bumped the version of the runtime api trait and then you should have handled this gracefully. Aka check which runtime api version is present and then call the correct method.
To justify myself: the breaking change was explicitly highlighted in #2714. There was also question raised on how we should handle this (aka can we break compatibility with v1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plain
people-kusamaandcoretime-kusamachainspecs were uploaded at #3961. Only binaries with compatible runtime versions can run with plain chainspec. For example:One of the latest master builds fails:
Master build from 5 days ago:
Changes:
Tests:
New chainspec can run on the latest master build:
Plain chainspec will fail: