Added tests for XCM barriers: AllowSubscriptions, WithUniqueTopic and TrailingSetTopicAsId#3955
Merged
Added tests for XCM barriers: AllowSubscriptions, WithUniqueTopic and TrailingSetTopicAsId#3955
AllowSubscriptions, WithUniqueTopic and TrailingSetTopicAsId#3955Conversation
… and `TrailingSetTopicAsId`
bkontur
added
R0-no-crate-publish-required
acatangiu
approved these changes
Apr 3, 2024
svyatonik
approved these changes
Apr 3, 2024
serban300
approved these changes
Apr 3, 2024
| SetTopic([0; 32]), | ||
| ]); | ||
|
|
||
| let test_data = vec
There was a problem hiding this comment.
Nit: Not very important, but personally I would find it easier to follow and I think it would also be more extensible if we just asserted each case separately instead of iterating through a vec. I don't think it would create a lot of duplication.
Contributor
Author
There was a problem hiding this comment.
I saw this pattern on several other places and also used it elsewhere, where I had much more test data (corner) cases than just 4 here :)
As a part of #3692 I will add a new barrier, so I will come back to this and simplify.
dharjeezy
pushed a commit
to dharjeezy/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
… and `TrailingSetTopicAsId` (paritytech#3955) Closes: paritytech#1756
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1756