Skip to content

Small crypto refactory#3669

Closed
davxy wants to merge 20 commits intoparitytech:masterfrom
davxy:davxy-crypto-refactory
Closed

Small crypto refactory#3669
davxy wants to merge 20 commits intoparitytech:masterfrom
davxy:davxy-crypto-refactory

Conversation

@davxy
Copy link
Copy Markdown
Member

@davxy davxy commented Mar 12, 2024

  • Move Public and Signature associated types from Pair to Crypto trait (thus being more close to AppCrypto pattern)
  • More strict type checking for Crypto trait associated types (also allows a more ergonomic usage)
  • impl_crypto_type macro to implement Crypto for the (Secret, Public, Signature) triple
  • Introduces the Signature trait which serves a similar purpose of Public trait

Depends on #3684 (follow up)

@davxy davxy added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Mar 12, 2024
@davxy davxy self-assigned this Mar 12, 2024
@davxy davxy added the A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Mar 12, 2024
@paritytech paritytech deleted a comment from paritytech-cicd-pr Mar 13, 2024
@paritytech paritytech deleted a comment from paritytech-cicd-pr Mar 13, 2024
@paritytech-cicd-pr
Copy link
Copy Markdown

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5627332

@davxy davxy closed this Apr 29, 2024
@davxy davxy deleted the davxy-crypto-refactory branch April 29, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants