Skip to content

move integrity tests feature of insecure-ed-zero#3645

Closed
girazoki wants to merge 2 commits intoparitytech:masterfrom
girazoki:girazoki-apply-insecure-ed-zero-correctly-integrity-tests
Closed

move integrity tests feature of insecure-ed-zero#3645
girazoki wants to merge 2 commits intoparitytech:masterfrom
girazoki:girazoki-apply-insecure-ed-zero-correctly-integrity-tests

Conversation

@girazoki
Copy link
Copy Markdown
Contributor

Simple PR just moving the insecure-ed-zero only to its appropriate assert

@girazoki girazoki requested a review from a team as a code owner March 11, 2024 13:17
@girazoki
Copy link
Copy Markdown
Contributor Author

girazoki commented Mar 11, 2024

Also is there a reason why we are only testing maxFreezes and not maxHolds?

@ggwpez
Copy link
Copy Markdown
Member

ggwpez commented Mar 11, 2024

Also is there a reason why we are only testing maxFreezes and not maxHolds?

Hm i dont think so... please add it then.

@girazoki
Copy link
Copy Markdown
Contributor Author

Also is there a reason why we are only testing maxFreezes and not maxHolds?

Hm i dont think so... please add it then.

Will do yes

@girazoki
Copy link
Copy Markdown
Contributor Author

Also is there a reason why we are only testing maxFreezes and not maxHolds?

Hm i dont think so... please add it then.

Ah sorry, it seems there is no need for that according to #2657:

In addition, MaxHolds is removed (as suggested https://github.com/paritytech/polkadot-sdk/pull/2657#discussion_r1443324573) from pallet_balances, and its Holds are now bounded to RuntimeHoldReason::VARIANT_COUNT. Therefore, there is no need to let the runtime specify MaxHolds.

@bkchr bkchr requested a review from ggwpez July 17, 2024 12:48
@bkchr bkchr added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Jul 17, 2024
@bkchr bkchr enabled auto-merge July 17, 2024 12:49
@ggwpez
Copy link
Copy Markdown
Member

ggwpez commented Jul 17, 2024

Looks like we already did this and this MR became a No-OP. Closing.
Screenshot 2024-07-17 at 23 12 37

@ggwpez ggwpez closed this Jul 17, 2024
auto-merge was automatically disabled July 17, 2024 21:12

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants