Make penpal-runtime's TrustedReserves more connfigurable (#3564) (patch for 1.8.0)#3625
Merged
acatangiu merged 1 commit intorelease-crates-io-v1.8.0from Mar 11, 2024
Merged
Conversation
The current `penpal` runtime utilizes the `EthereumLocation` parameter, which is employed for XCM emulated integration tests concerning the Rococo <> ETH bridge. It includes a hard-coded chainId for the Ethereum testnet utilized in Rococo. The `EthereumLocation` serves the purpose of aligning with the `TrustedReserves`. However, due to this hard-coded configuration, reusing `penpal` for testing various environments such as Kusama/Polkadot versus Ethereum bridge becomes unfeasible. This PR introduces the capability to easily customize the asset location for `TrustedReserves` without needing to know anything about Ethereum. ## TODO - [x] fix integration tests with `System::set_storage(CustomizableAssetFromSystemAssetHub::key(), <whatever-location-is-needed>)` @claravanstaden - [ ] ~~maybe add some helper function/macro to support `set_storage` for other runtimes (that we could reuse)~~ - [ ] Release patch for: `penpal-runtime` + emulated crate with `set_storage` support (if needed) - [ ] backport to 1.7.0 - [ ] backport to 1.8.0 --------- Co-authored-by: Clara van Staden <[email protected]> # Conflicts: # cumulus/parachains/runtimes/testing/penpal/Cargo.toml # Conflicts: # Cargo.lock # cumulus/parachains/runtimes/testing/penpal/Cargo.toml
5 tasks
franciscoaguirre
approved these changes
Mar 8, 2024
bkontur
added
the
R0-no-crate-publish-required
seadanda
approved these changes
Mar 8, 2024
acatangiu
requested changes
Mar 8, 2024
Contributor
acatangiu
left a comment
acatangiu
left a comment
There was a problem hiding this comment.
why all the Cargo.lock changes?
Contributor
Author
I think, because actual E.g. actual version of You can try it with checkout of |
acatangiu
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3564
Expected patches for (1.8.0):
0.16.1