Skip to content

Deprecate xcm::body::TREASURER_INDEX constant, use standard Treasury varian instead#3608

Merged
muharem merged 3 commits into
masterfrom
muharem-deprecate-treasurer-origin-index
Mar 7, 2024
Merged

Deprecate xcm::body::TREASURER_INDEX constant, use standard Treasury varian instead#3608
muharem merged 3 commits into
masterfrom
muharem-deprecate-treasurer-origin-index

Conversation

@muharem
Copy link
Copy Markdown
Contributor

@muharem muharem commented Mar 7, 2024

Deprecate the xcm::body::TREASURER_INDEX constant and use the standard Treasury variant from the xcm::BodyId type instead.

To align with the production runtimes: polkadot-fellows/runtimes#149

@muharem muharem added R0-no-crate-publish-required The change does not require any crates to be re-published. T9-cumulus This PR/Issue is related to cumulus. labels Mar 7, 2024
const ROOT_INDEX: u32 = 0;
// The bodies corresponding to the Polkadot OpenGov Origins.
pub const FELLOWSHIP_ADMIN_INDEX: u32 = 1;
#[deprecated = "Will be removed after August 2024; Use `xcm::latest::BodyId::Treasury` \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just remove it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make sure none uses the same index for the time of deprecation

@muharem muharem requested a review from ggwpez March 7, 2024 11:49
@muharem muharem enabled auto-merge March 7, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published. T9-cumulus This PR/Issue is related to cumulus.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants