sc-manual-seal: don't spawn threads in tests#3595
Merged
Conversation
andresilva
added
R0-no-crate-publish-required
lexnv
approved these changes
Mar 6, 2024
michalkucharczyk
approved these changes
Mar 6, 2024
Contributor
|
We could run this test 20x (by modyfying gitlab-ci files) in this particular PR just to test if the fix works? |
athei
approved these changes
Mar 6, 2024
Contributor
Author
I'll open a draft PR to try and replicate this in CI. |
Contributor
|
@andresilva can you add timeouts the I'm not sure why it failed but could that too many threads were created and spawning the thread crashed then the future was not executed? |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Unfortunately, the flakiness wasn't fixed by #3595. Let's disable the test in the meanwhile since it is hanging on the CI a lot. --------- Co-authored-by: Liam Aharon <[email protected]>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Hopefully helps with test flakiness.
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Unfortunately, the flakiness wasn't fixed by paritytech#3595. Let's disable the test in the meanwhile since it is hanging on the CI a lot. --------- Co-authored-by: Liam Aharon <[email protected]>
This was referenced Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully helps with test flakiness.