Skip to content

Fixes snowbridge integration test#3570

Merged
bkontur merged 5 commits intoparitytech:bko-penpal-customizationfrom
Snowfork:clara-penpal-customization
Mar 6, 2024
Merged

Fixes snowbridge integration test#3570
bkontur merged 5 commits intoparitytech:bko-penpal-customizationfrom
Snowfork:clara-penpal-customization

Conversation

@claravanstaden
Copy link
Contributor

@claravanstaden claravanstaden commented Mar 5, 2024

Fixes the snowbridge test by using the new Penpal config.

@claravanstaden claravanstaden marked this pull request as ready for review March 5, 2024 07:06
@claravanstaden claravanstaden requested a review from a team as a code owner March 5, 2024 07:24
@acatangiu acatangiu added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Mar 5, 2024
rococo-westend-system-emulated-network = { path = "../../../networks/rococo-westend-system" }
rococo-system-emulated-network = { path = "../../../networks/rococo-system" }
asset-hub-rococo-runtime = { path = "../../../../../runtimes/assets/asset-hub-rococo", default-features = false }
penpal-runtime = { path = "../../../../../runtimes/testing/penpal", default-features = false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4c2ca7b.

]);

PenpalA::execute_with(|| {
<PenpalA as Chain>::System::set_storage(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claravanstaden remove unwrap and use assert_ok!( instead please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 4c2ca7b.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5449632

rococo-westend-system-emulated-network = { path = "../../../networks/rococo-westend-system" }
rococo-system-emulated-network = { path = "../../../networks/rococo-system" }
asset-hub-rococo-runtime = { path = "../../../../../runtimes/assets/asset-hub-rococo", default-features = false }
penpal-emulated-chain = { path = "../../../chains/parachains/testing/penpal", default-features = false }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claravanstaden I think no need to add this deps here, because it can be reached from rococo-system-emulated-network, I will try it in my branch

@bkontur bkontur merged commit d3d9a1d into paritytech:bko-penpal-customization Mar 6, 2024
@claravanstaden claravanstaden deleted the clara-penpal-customization branch March 6, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants