Improve Penpal runtime + emulated tests by NachoPal · Pull Request #3543 · paritytech/polkadot-sdk

NachoPal · 2024-03-01T12:23:38Z

Issues addressed in this PR:

Improve Penpal runtime:
- Properly handled received assets. Previously, it treated (1, Here) as the local native currency, whereas it should be treated as a ForeignAsset. This wasn't a great example of standard Parachain behaviour, as no Parachain treats the system asset as the local currency.
- Remove AllowExplicitUnpaidExecutionFrom the system. Again, this wasn't a great example of standard Parachain behaviour.
Move duplicated ForeignAssetFeeAsExistentialDepositMultiplierFeeCharger to assets_common crate.
Improve emulated tests:
- Update Penpal tests to new runtime.
- To simplify tests, register the reserve transferred, teleported, and system assets in Penpal and AssetHub genesis. This saves us from having to create the assets repeatedly for each test
- Add missing test case: reserve_transfer_assets_from_para_to_system_para.
- Cleanup.
Prevent integration tests crates imports from being re-exported, as they were polluting the polkadot-sdk docs.

There is still a test case missing for reserve transfers:

Reserve transfer of system asset from Parachain to Parachain trough AssetHub.
This is not yet possible with pallet-xcm due to the reasons explained in Improve Penpal runtime/emulated tests + AssetHub TokenLocationAsNative #3339

NachoPal · 2024-03-01T13:59:58Z

bot fmt

command-bot · 2024-03-01T14:00:03Z

@NachoPal https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5410423 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 11-31935f3e-e51f-4120-86ce-e2e26f9b9740 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-03-01T14:01:57Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5410423 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5410423/artifacts/download.

cumulus/parachains/integration-tests/emulated/common/src/macros.rs

...us/parachains/integration-tests/emulated/tests/assets/asset-hub-rococo/src/tests/teleport.rs

NachoPal · 2024-03-04T13:26:50Z

bot fmt

command-bot · 2024-03-04T13:26:56Z

@NachoPal https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5426126 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-2e3f115a-f527-4a3b-8cea-9f232734be87 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-03-04T14:34:22Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5426126 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5426126/artifacts/download.

…-sdk into nacho/improve-penpal

cumulus/parachains/runtimes/assets/common/src/lib.rs

cumulus/parachains/runtimes/assets/common/Cargo.toml

cumulus/parachains/runtimes/testing/penpal/src/xcm_config.rs

cumulus/parachains/integration-tests/emulated/common/src/lib.rs

cumulus/parachains/integration-tests/emulated/tests/assets/asset-hub-rococo/Cargo.toml

NachoPal · 2024-03-11T17:06:10Z

bot fmt

command-bot · 2024-03-11T17:06:15Z

@NachoPal https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5494268 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-b857f1c0-b790-425a-a6eb-0e91452ff520 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-03-11T17:10:04Z

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5494268 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5494268/artifacts/download.

NachoPal · 2024-03-12T09:42:18Z

@bkontur Addressed the comments, please take a look.

bkontur · 2024-03-14T10:25:08Z

cumulus/parachains/integration-tests/emulated/common/src/lib.rs

+// This asset is added to AH as ForeignAsset and teleported between Penpal and AH
+pub const TELEPORTABLE_ASSET_ID: u32 = 2;
+
+pub const PENPAL_ID: u32 = 2000;


we have also: https://github.com/paritytech/polkadot-sdk/pull/3543/files#diff-528b20b59bd1a15fbb063551a37e733ffa9b1e61c2d6ac30039e8d15271f5122R29-R30

pub const PARA_ID_A: u32 = 2000; pub const PARA_ID_B: u32 = 2001;

so shouldn't be PenpalTeleportableAssetLocation and PenpalSiblingSovereigAccount specific for A and/or B?
E.g.:
PenpalATeleportableAssetLocation
PenpalBTeleportableAssetLocation

bkontur

lgtm, just one last nit/question: https://github.com/paritytech/polkadot-sdk/pull/3543/files#r1524603274

* master: (65 commits) collator protocol changes for elastic scaling (validator side) (#3302) Contracts use polkavm workspace deps (#3715) Add elastic scaling support in ParaInherent BenchBuilder (#3690) Removes `as [disambiguation_path]` from `derive_impl` usage (#3652) fix(paseo-spec): New Paseo Bootnodes (#3674) Improve Penpal runtime + emulated tests (#3543) Staking ledger bonding fixes (#3639) DescribeAllTerminal for HashedDescription (#3349) Increase timeout for assertions (#3680) Add subsystems regression tests to CI (#3527) Always print connectivity report (#3677) Revert "FRAME: Create `TransactionExtension` as a replacement for `SignedExtension` (#2280)" (#3665) authority-discovery: Add log for debugging DHT authority records (#3668) Construct Runtime v2 (#1378) Support for `keyring` in runtimes (#2044) Add api-name in `cannot query the runtime API version` warning (#3653) Add a PolkaVM-based executor (#3458) Adds default config for assets pallet (#3637) Bump handlebars from 4.3.7 to 5.1.0 (#3248) [Collator Selection] Fix weight refund for `set_candidacy_bond` (#3643) ...

Issues addressed in this PR: - Improve *Penpal* runtime: - Properly handled received assets. Previously, it treated `(1, Here)` as the local native currency, whereas it should be treated as a `ForeignAsset`. This wasn't a great example of standard Parachain behaviour, as no Parachain treats the system asset as the local currency. - Remove `AllowExplicitUnpaidExecutionFrom` the system. Again, this wasn't a great example of standard Parachain behaviour. - Move duplicated `ForeignAssetFeeAsExistentialDepositMultiplierFeeCharger` to `assets_common` crate. - Improve emulated tests: - Update *Penpal* tests to new runtime. - To simplify tests, register the reserve transferred, teleported, and system assets in *Penpal* and *AssetHub* genesis. This saves us from having to create the assets repeatedly for each test - Add missing test case: `reserve_transfer_assets_from_para_to_system_para`. - Cleanup. - Prevent integration tests crates imports from being re-exported, as they were polluting the `polkadot-sdk` docs. There is still a test case missing for reserve transfers: - Reserve transfer of system asset from *Parachain* to *Parachain* trough *AssetHub*. - This is not yet possible with `pallet-xcm` due to the reasons explained in paritytech#3339 --------- Co-authored-by: command-bot <>

NachoPal added 9 commits February 15, 2024 14:11

improve penpal + assethub local asset change

5c21fd6

merge master

79792af

apply changes to westend

13d958a

merge master

2ad94e3

asset-hub-rococo&westend test working

1e845b8

fix imports

01e483c

add para to ah test

4e56979

cleanup

991fc0e

fmt

62b9e88

NachoPal added T14-system_parachains This PR/Issue is related to system parachains. R0-no-crate-publish-required The change does not require any crates to be re-published. labels Mar 1, 2024

NachoPal added 3 commits March 1, 2024 14:33

fix feature propagation

777df2a

make clippy happy

ba01023

make clippy happy 2

158e12f

command-bot and others added 2 commits March 1, 2024 14:01

".git/.scripts/commands/fmt/fmt.sh"

750e22c

Merge branch 'master' into nacho/improve-penpal

0fc33ab

NachoPal mentioned this pull request Mar 1, 2024

Improve Penpal runtime/emulated tests + AssetHub TokenLocationAsNative #3339

Draft

NachoPal requested review from acatangiu and joepetrowski March 1, 2024 14:19

NachoPal marked this pull request as ready for review March 1, 2024 14:19

acatangiu reviewed Mar 1, 2024

View reviewed changes

cumulus/parachains/integration-tests/emulated/common/src/macros.rs Show resolved Hide resolved

...us/parachains/integration-tests/emulated/tests/assets/asset-hub-rococo/src/tests/teleport.rs Show resolved Hide resolved

address comments

c6dbbb9

".git/.scripts/commands/fmt/fmt.sh"

ecc8968

acatangiu approved these changes Mar 4, 2024

View reviewed changes

acatangiu mentioned this pull request Mar 4, 2024

Make penpal-runtime's TrustedReserves more connfigurable #3564

Merged

5 tasks

NachoPal added 2 commits March 4, 2024 16:30

make clippy happy

4590d3e

Merge branch 'nacho/improve-penpal' of github.com:paritytech/polkadot…

8aabd6d

…-sdk into nacho/improve-penpal

NachoPal requested a review from bkontur March 4, 2024 15:35

NachoPal enabled auto-merge March 5, 2024 09:14

bkontur reviewed Mar 5, 2024

View reviewed changes

NachoPal added 2 commits March 11, 2024 17:58

address comments

176f63e

merge master

c62b0e9

".git/.scripts/commands/fmt/fmt.sh"

e9614a3

NachoPal added 2 commits March 11, 2024 18:27

fix

30f80ad

clippy

3af08a5

NachoPal requested a review from bkontur March 12, 2024 09:41

bkontur reviewed Mar 14, 2024

View reviewed changes

bkontur approved these changes Mar 14, 2024

View reviewed changes

NachoPal added this pull request to the merge queue Mar 14, 2024

Merged via the queue into master with commit cfc4050 Mar 14, 2024

NachoPal deleted the nacho/improve-penpal branch March 14, 2024 10:51

Conversation

NachoPal commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NachoPal commented Mar 1, 2024

Uh oh!

command-bot bot commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 1, 2024

Uh oh!

Uh oh!

Uh oh!

NachoPal commented Mar 4, 2024

Uh oh!

command-bot bot commented Mar 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NachoPal commented Mar 11, 2024

Uh oh!

command-bot bot commented Mar 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Mar 11, 2024

Uh oh!

NachoPal commented Mar 12, 2024

Uh oh!

bkontur Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

bkontur left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NachoPal commented Mar 1, 2024 •

edited

Loading

command-bot bot commented Mar 1, 2024 •

edited

Loading

command-bot bot commented Mar 4, 2024 •

edited

Loading

command-bot bot commented Mar 11, 2024 •

edited

Loading