Fix wasm-builder not exiting if compilation fails#3439
Merged
koute merged 2 commits intoparitytech:masterfrom Feb 22, 2024
Merged
Fix wasm-builder not exiting if compilation fails#3439koute merged 2 commits intoparitytech:masterfrom
wasm-builder not exiting if compilation fails#3439koute merged 2 commits intoparitytech:masterfrom
Conversation
koute
added
R0-no-crate-publish-required
michalkucharczyk
approved these changes
Feb 22, 2024
davxy
approved these changes
Feb 22, 2024
bkchr
approved these changes
Feb 22, 2024
girazoki
pushed a commit
to moondance-labs/polkadot-sdk
that referenced
this pull request
Feb 22, 2024
This PR fixes a subtle bug in `wasm-builder` first introduced in paritytech#1851 (sorry, my bad! I should have caught this during review) where the status code of the `cargo` subprocess is not properly checked, which results in builds silently succeeding when they shouldn't (that is: if we successfully build a runtime blob, and then modify the code so that it won't compile, and recompile it again, then the build will succeed and silently use the *old* blob). cc @athei This is the bug you were seeing. [edit]Also fixes a similar PolkaVM-specific bug where I accidentally used the wrong comparison operator.[/edit]
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
This PR fixes a subtle bug in `wasm-builder` first introduced in paritytech#1851 (sorry, my bad! I should have caught this during review) where the status code of the `cargo` subprocess is not properly checked, which results in builds silently succeeding when they shouldn't (that is: if we successfully build a runtime blob, and then modify the code so that it won't compile, and recompile it again, then the build will succeed and silently use the *old* blob). cc @athei This is the bug you were seeing. [edit]Also fixes a similar PolkaVM-specific bug where I accidentally used the wrong comparison operator.[/edit]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a subtle bug in
wasm-builderfirst introduced in #1851 (sorry, my bad! I should have caught this during review) where the status code of thecargosubprocess is not properly checked, which results in builds silently succeeding when they shouldn't (that is: if we successfully build a runtime blob, and then modify the code so that it won't compile, and recompile it again, then the build will succeed and silently use the old blob).cc @athei This is the bug you were seeing.
[edit]Also fixes a similar PolkaVM-specific bug where I accidentally used the wrong comparison operator.[/edit]