Skip to content

Add more debug logs to understand if statement-distribution misbehaving#3419

Merged
alexggh merged 12 commits into
masterfrom
alexaggh/num_parallel_requests
Feb 26, 2024
Merged

Add more debug logs to understand if statement-distribution misbehaving#3419
alexggh merged 12 commits into
masterfrom
alexaggh/num_parallel_requests

Conversation

@alexggh

@alexggh alexggh commented Feb 21, 2024

Copy link
Copy Markdown
Contributor

Add more debug logs to understand if statement-distribution is in a bad state, should be useful for debugging #3314 on production networks.

Additionally, increase the number of parallel requests should make, since I notice that requests take around 100ms on kusama, and the 5 parallel request was picked mostly random, no reason why we can do more than that.

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh alexggh changed the title Add more debug logs to understand statement-distribution misbehaving Add more debug logs to understand if statement-distribution misbehaving Feb 22, 2024
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
alexggh marked this pull request as ready for review February 23, 2024 14:48
Comment thread polkadot/node/network/statement-distribution/src/v2/cluster.rs
Comment thread polkadot/node/network/statement-distribution/src/v2/mod.rs Outdated
Comment thread polkadot/node/network/statement-distribution/src/v2/cluster.rs Outdated
alexggh and others added 2 commits February 25, 2024 19:50
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Co-authored-by: ordian <write@reusable.software>
@alexggh
alexggh enabled auto-merge February 26, 2024 07:11
@alexggh alexggh added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Feb 26, 2024
@alexggh
alexggh added this pull request to the merge queue Feb 26, 2024
Merged via the queue into master with commit b9c792a Feb 26, 2024
@alexggh
alexggh deleted the alexaggh/num_parallel_requests branch February 26, 2024 08:29
alexggh added a commit that referenced this pull request Feb 26, 2024
…ng (#3419)

Add more debug logs to understand if statement-distribution is in a bad
state, should be useful for debugging
#3314 on production
networks.

Additionally, increase the number of parallel requests should make,
since I notice that requests take around 100ms on kusama, and the 5
parallel request was picked mostly random, no reason why we can do more
than that.

---------

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Co-authored-by: ordian <write@reusable.software>
(cherry picked from commit b9c792a)
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
ordian added a commit that referenced this pull request Feb 28, 2024
…head-data

* origin/master: (51 commits)
  Runtime Upgrade ref docs and Single Block Migration example pallet  (#1554)
  Collator overseer builder unification (#3335)
  Introduce storage attr macro `#[disable_try_decode_storage]` and set it on `System::Events` and `ParachainSystem::HostConfiguration` (#3454)
  Add Polkadotters bootnoders per IBP application (#3423)
  Add documentation around FRAME Origin (#3362)
  Bridge zombienet tests: Check amount received at destination (#3490)
  Snowbridge benchmark tests fix (#3424)
  fix(zombienet): increase timeout in download artifacts (#3376)
  Cleanup String::from_utf8 (#3446)
  [prdoc] Validate crate names (#3467)
  Limit max execution time for `test-linux-stable` CI jobs (#3483)
  Introduce Notification block pinning limit (#2935)
  frame-support: Improve error reporting when having too many pallets (#3478)
  add Encointer as trusted teleporter for Westend (#3411)
  [pallet-xcm] Adjust benchmarks (teleport_assets/reserve_transfer_assets) not relying on ED (#3464)
  Add more debug logs to understand if statement-distribution misbehaving (#3419)
  Remove redundant parachains assigner pallet. (#3457)
  Use generic hash for runtime wasm in resolve_state_version_from_wasm (#3447)
  Runtime: allow backing multiple candidates of same parachain on different cores  (#3231)
  Bridge zombienet tests: move all "framework" files under one folder (#3462)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants