Add Paseo NetworkId for the new testnet to XCM#3328
Add Paseo NetworkId for the new testnet to XCM#3328franciscoaguirre wants to merge 7 commits intomasterfrom
Conversation
|
bot fmt |
|
@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5219438 was started for your command Comment |
|
@franciscoaguirre Command |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
| BitcoinCash => Self::BitcoinCash, | ||
| PolkadotBulletin => Self::PolkadotBulletin, | ||
| } | ||
| Paseo => return Err(()), |
There was a problem hiding this comment.
@franciscoaguirre i'm struggling to understand the logic here: Why Paseo would return an error?
This means that Paseo NetworkId would not be supported for XCM v3?
|
umm… Gav told me XCM v4 is only rename and therefore does not require RFC. but I guess that’s not the case anymore? This is a breaking change is someway so https://forum.polkadot.network/t/improve-xcm-development-and-release-process/6497 |
|
@hbulgarini @xlc Let's go through the RFC process and aim for V5 with this |
|
Not needed anymore. |
5 participants
NOTE
This needs an RFC discussion (TBD) that, if approved, should happen at minimum in v5.
Added Paseo Network Id to XCMv4
Given the new Paseo testnet and how it will be used in the ecosystem, it sounded like a good idea for it to have its own
NetworkId.Conversion from v4::NetworkId to v3::NetworkId is now fallible
Because all
NetworkIds were the same in both v3 and v4, the conversions between them were infallible. Now,v4::NetworkIdcontains an extra variant, so the conversion from it tov3::NetworkIdis fallible. The only case were there'll be an error is if the new "Paseo"NetworkIdtries to be converted into v3.