Skip to content

pallet-membership weights#3324

Merged
ggwpez merged 11 commits into
paritytech:masterfrom
Dinonard:dinonard/pallet-membership-weights
Feb 23, 2024
Merged

pallet-membership weights#3324
ggwpez merged 11 commits into
paritytech:masterfrom
Dinonard:dinonard/pallet-membership-weights

Conversation

@Dinonard
Copy link
Copy Markdown
Contributor

Summary

  • use benchamarked weights instead of hardcoded ones for pallet-membership
  • rename benchmark to match extrinsic name
  • remove unnecessary dependency from clear_prime

@Dinonard Dinonard requested a review from a team as a code owner February 14, 2024 13:08
Copy link
Copy Markdown
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 😅

Comment thread substrate/frame/membership/src/lib.rs
Comment thread substrate/frame/membership/src/migrations/v4.rs Outdated
@paritytech-review-bot paritytech-review-bot Bot requested a review from a team February 14, 2024 15:03
Comment thread substrate/frame/membership/src/lib.rs Outdated
@Dinonard
Copy link
Copy Markdown
Contributor Author

Can this be merged or is there something else I should do?

@ggwpez ggwpez added R0-no-crate-publish-required The change does not require any crates to be re-published. and removed R0-no-crate-publish-required The change does not require any crates to be re-published. labels Feb 19, 2024
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez enabled auto-merge February 19, 2024 18:00
@ggwpez ggwpez added the T2-pallets This PR/Issue is related to a particular pallet. label Feb 19, 2024
@ggwpez ggwpez added this pull request to the merge queue Feb 23, 2024
Merged via the queue into paritytech:master with commit 5fc6d67 Feb 23, 2024
@Dinonard Dinonard deleted the dinonard/pallet-membership-weights branch February 23, 2024 14:33
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
## Summary
* use benchamarked weights instead of hardcoded ones for
`pallet-membership`
* rename benchmark to match extrinsic name
* remove unnecessary dependency from `clear_prime`

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T2-pallets This PR/Issue is related to a particular pallet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants