Skip to content

Add broker pallet to coretime-westend#3272

Merged
seadanda merged 21 commits intomasterfrom
donal-coretime-westend
Feb 16, 2024
Merged

Add broker pallet to coretime-westend#3272
seadanda merged 21 commits intomasterfrom
donal-coretime-westend

Conversation

@seadanda
Copy link
Copy Markdown
Contributor

@seadanda seadanda commented Feb 8, 2024 •
edited
Loading

This brings functionality to Westend's Coretime Chain runtime, where previously it was not much more than a shell.

It is assumed that the Coretime pallet will have the same index in the Westend runtime as it does in Rococo for the runtime calls.

TODO:

  • Generate chainspec
  • Regenerate weights
  • Check hardcoded RuntimeCall weights against relay weights for transacts

Aura key generation: https://github.com/paritytech/devops/issues/2725

@seadanda seadanda added the T14-system_parachains This PR/Issue is related to system parachains. label Feb 8, 2024
@seadanda seadanda self-assigned this Feb 8, 2024
@seadanda seadanda requested a review from a team as a code owner February 8, 2024 17:18
@seadanda
Copy link
Copy Markdown
Contributor Author

seadanda commented Feb 8, 2024

bot bench-all cumulus --runtime=coretime-westend

@command-bot
Copy link
Copy Markdown

command-bot bot commented Feb 8, 2024 •
edited
Loading

@seadanda "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=coretime-westend --target_dir=cumulus (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5162799) was cancelled in #3272 (comment)

@seadanda
Copy link
Copy Markdown
Contributor Author

seadanda commented Feb 8, 2024

bot cancel

@command-bot
Copy link
Copy Markdown

command-bot bot commented Feb 8, 2024

@seadanda Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=coretime-westend --target_dir=cumulus has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5162799 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5162799/artifacts/download.

@seadanda
Copy link
Copy Markdown
Contributor Author

seadanda commented Feb 8, 2024

bot bench-all cumulus --runtime=coretime-westend

@command-bot
Copy link
Copy Markdown

command-bot bot commented Feb 8, 2024 •
edited
Loading

@seadanda https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5165413 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=coretime-westend --target_dir=cumulus. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-719b645f-20a9-4047-a4cf-6efbfcd469be to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link
Copy Markdown

command-bot bot commented Feb 8, 2024

@seadanda Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=coretime-westend --target_dir=cumulus has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5165413 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5165413/artifacts/download.

@paritytech-cicd-pr
Copy link
Copy Markdown

paritytech-cicd-pr commented Feb 9, 2024

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5165711

@antonva antonva mentioned this pull request Feb 14, 2024
Merged
1 task
bkchr
bkchr approved these changes Feb 14, 2024
View reviewed changes
@seadanda seadanda enabled auto-merge February 16, 2024 12:42
@seadanda seadanda added this pull request to the merge queue Feb 16, 2024
Merged via the queue into master with commit 9923444 Feb 16, 2024
@seadanda seadanda deleted the donal-coretime-westend branch February 16, 2024 13:33
@BulatSaif BulatSaif mentioned this pull request Feb 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 19, 2024
@antonva @bkchr
Add Coretime to Westend (#3319)
320863a 
Adds the coretime and on demand pallets to enable Coretime on Westend. 
In order for the migration to run successfully, we need the
Broker/Coretime parachain to be live.

TODO:
- [ ] Broker parachain is live
#3272

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
ordian added a commit that referenced this pull request Feb 19, 2024
@ordian
Merge branch 'master' into ao-collator-parent-head-data
739e63c 
* master: (41 commits)
  Add Coretime to Westend (#3319)
  removed `pallet::getter` from `pallet-sudo` (#3370)
  gossip-support: add unittests for update authorities (#3258)
  [FRAME Core] remove unnecessary overrides while using derive_impl for frame_system (#3317)
  Update coretime-westend bootnodes (#3380)
  `im-online` removal cleanup: remove off-chain storage (#2290)
  Bump the known_good_semver group with 1 update (#3379)
  Fix documentation dead link (#3372)
  Make `sp-keystore` `no_std`-compatible and fix the `build-runtimes-polkavm` CI job (#3363)
  Remove unused `im-online` weights (#3373)
  Ensure referenda `TracksInfo` is sorted (#3325)
  rpc server: add rate limiting middleware (#3301)
  do not block finality for "disabled" disputes (#3358)
  fix(zombienet): docker `img` version to use in merge queues for bridges (#3337)
  Various nits and alignments for SP testnets found during bumping `polkadot-fellows` repo (#3359)
  Add broker pallet to `coretime-westend` (#3272)
  remove recursion limit (#3348)
  Update subkey README.md (#3355)
  Bump the known_good_semver group with 6 updates (#3347)
  Document LocalKeystore insert method (#3336)
  ...
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@seadanda @bkchr @antonva
Add broker pallet to coretime-westend (paritytech#3272)
65d3d08 
This brings functionality to Westend's Coretime Chain runtime, where
previously it was not much more than a shell.

It is assumed that the Coretime pallet will have the same index in the
Westend runtime as it does in Rococo for the runtime calls.

TODO:
- [x] Generate chainspec
- [x] Regenerate weights
- [x] Check hardcoded RuntimeCall weights against relay weights for
transacts

Aura key generation: paritytech/devops#2725

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Anton Vilhelm Ásgeirsson <[email protected]>
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkchr bkchr bkchr approved these changes

@bkontur bkontur bkontur left review comments

+1 more reviewer

@antonva antonva antonva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seadanda seadanda

Labels

T14-system_parachains This PR/Issue is related to system parachains.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seadanda @paritytech-cicd-pr @antonva @bkchr @bkontur