subsystem-bench: Prepare CI output#3158
Conversation
| agent_ready.shutdown(); | ||
| } | ||
|
|
||
| let output = if self.ci { serde_yaml::to_string(&vec![usage])? } else { usage.to_string() }; |
There was a problem hiding this comment.
Nit: This logic is duplicated you can move it in a small funciton.
There was a problem hiding this comment.
You're right. But we're going to remove the last branch and keep only run with test files. So this duplication is going to be removed as well.
|
|
||
| #[clap(long, default_value_t = false)] | ||
| /// Shows the output in YAML format | ||
| pub ci: bool, |
There was a problem hiding this comment.
Probably we can find a better name here like:
--output-format=yaml
--output-format=json
or even simpler
--yaml-output
There was a problem hiding this comment.
I think we can start with more obvious --yaml-output, because I have no plans for additional json one :-)
sandreim
left a comment
There was a problem hiding this comment.
LGTM! I also suggest to include the test objective in the output.
I think we add it as a title here, or you mean something else? |
Yes, currently you print just the seq file name. |
Co-authored-by: Andrei Sandu <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.