Merged
Conversation
| GenesisBlockBuilder, | ||
| }, | ||
| genesis_config_builder::GenesisConfigBuilderRuntimeCaller, | ||
| json_patch::merge as json_merge, |
Contributor
Author
There was a problem hiding this comment.
Maybe not most elegant solution, but I don't want to add crate for this single tiny merge function. Let me know if it is ok.
bkchr
approved these changes
Jan 25, 2024
bkchr
added
the
R0-no-crate-publish-required
davxy
approved these changes
Jan 25, 2024
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
We don't need dependency on `json_patch` there is implementation of needed function in `sc_chain_spec` crate. This PR makes this function publicly available and removes the dep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need dependency on
json_patchthere is implementation of needed function insc_chain_speccrate.This PR makes this function publicly available and removes the dep.