Switch All `construct_runtime`s to New Syntax by joepetrowski · Pull Request #2979 · paritytech/polkadot-sdk

joepetrowski · 2024-01-18T09:04:48Z

Clean up all the old syntax.

bkchr

Thank you!!

joepetrowski · 2024-01-18T09:43:10Z

Actually, I can just do the Polkadot and Substrate ones too in this branch.

joepetrowski · 2024-01-18T10:15:02Z

bot fmt

command-bot · 2024-01-18T10:15:09Z

@joepetrowski https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4952118 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-3960744c-0acd-4dae-a460-8dd8441e7fab to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-01-18T10:17:32Z

@joepetrowski Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4952118 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4952118/artifacts/download.

gupnik

As discussed, might need to update the UI Test outputs.

This reverts commit a829837.

gupnik · 2024-01-19T02:49:41Z

bot update-ui

command-bot · 2024-01-19T02:49:47Z

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4963196 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-430e7d00-a6df-487e-a45e-7528899284c5 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-01-19T03:12:18Z

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4963196 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4963196/artifacts/download.

mordamax · 2024-01-19T13:20:49Z

bot update-ui

command-bot · 2024-01-19T13:20:54Z

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4970635 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-b6ca34d3-3c02-41a8-a174-5aa3648a19cb to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-01-19T13:45:56Z

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4970635 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4970635/artifacts/download.

joepetrowski · 2024-01-19T19:34:58Z

bot update-ui

command-bot · 2024-01-19T19:35:03Z

@joepetrowski https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4977096 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-10f8cbe7-7c3b-4818-93b5-e2184b74ecc6 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-01-19T19:58:24Z

@joepetrowski Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4977096 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4977096/artifacts/download.

mordamax · 2024-01-19T23:31:58Z

bot update-ui

command-bot · 2024-01-19T23:32:03Z

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978832 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-6f292ed2-ab07-4fb9-838f-6bfe4cffec1f to cancel this command or bot cancel to cancel all commands in this pull request.

mordamax · 2024-01-19T23:32:13Z

bot cancel

mordamax · 2024-01-19T23:32:42Z

bot update-ui

command-bot · 2024-01-19T23:32:46Z

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978833 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-c7832cf0-fc63-41d6-8e71-237f6f3589c0 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot · 2024-01-19T23:56:48Z

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978832 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978832/artifacts/download.

command-bot · 2024-01-19T23:57:26Z

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978833 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978833/artifacts/download.

Clean up all the old syntax. --------- Co-authored-by: command-bot <> Co-authored-by: gupnik <[email protected]> Co-authored-by: Nikhil Gupta <[email protected]> Co-authored-by: Maksym H <[email protected]>

switch all cumulus construct runtimes to new syntax

875050b

joepetrowski added R0-no-crate-publish-required The change does not require any crates to be re-published. T14-system_parachains This PR/Issue is related to system parachains. labels Jan 18, 2024

joepetrowski requested a review from seadanda January 18, 2024 09:04

bkchr approved these changes Jan 18, 2024

View reviewed changes

bkontur approved these changes Jan 18, 2024

View reviewed changes

seadanda approved these changes Jan 18, 2024

View reviewed changes

acatangiu approved these changes Jan 18, 2024

View reviewed changes

polkadot

dd72049

joepetrowski requested a review from a team as a code owner January 18, 2024 09:57

substrate

fa3ebd3

joepetrowski requested review from a team January 18, 2024 10:10

joepetrowski requested review from athei, cheme and jsidorenko as code owners January 18, 2024 10:10

joepetrowski requested a review from a team January 18, 2024 10:10

joepetrowski changed the title ~~Switch All Cumulus construct_runtimes to New Syntax~~ Switch All construct_runtimes to New Syntax Jan 18, 2024

".git/.scripts/commands/fmt/fmt.sh"

a829837

gupnik approved these changes Jan 18, 2024

View reviewed changes

joepetrowski added 6 commits January 18, 2024 12:58

Revert "".git/.scripts/commands/fmt/fmt.sh""

c8fc868

This reverts commit a829837.

update frame-support tests

481b61a

some format

c5bde48

fmt likes enums better

dc4cf48

add some moissing default genesis configs

937380f

kitchensink needs explicit imports

18a7fc6

gupnik added 2 commits January 19, 2024 07:52

Fixes another one

19e5ea9

Fixes a couple more

1ce8e8f

".git/.scripts/commands/update-ui/update-ui.sh"

c6ae113

Merge branch 'master' into joe-use-new-construct-runtime-system-paras

49392e5

jsidorenko approved these changes Jan 19, 2024

View reviewed changes

Merge branch 'master' into joe-use-new-construct-runtime-system-paras

7f68af5

Merge branch 'master' into joe-use-new-construct-runtime-system-paras

04e9122

Updates tests with feature flag run

2c00c20

joepetrowski added this pull request to the merge queue Jan 22, 2024

Merged via the queue into master with commit 757ae37 Jan 22, 2024

joepetrowski deleted the joe-use-new-construct-runtime-system-paras branch January 22, 2024 07:57

github-actions bot mentioned this pull request Mar 13, 2024

Update polkadot-sdk from v1.3.0 to v1.7.2 moonbeam-foundation/moonbeam#2703

Closed

Conversation

joepetrowski commented Jan 18, 2024

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

joepetrowski commented Jan 18, 2024

Uh oh!

joepetrowski commented Jan 18, 2024

Uh oh!

command-bot bot commented Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jan 18, 2024

Uh oh!

gupnik left a comment

Choose a reason for hiding this comment

Uh oh!

gupnik commented Jan 19, 2024

Uh oh!

command-bot bot commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jan 19, 2024

Uh oh!

mordamax commented Jan 19, 2024

Uh oh!

command-bot bot commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jan 19, 2024

Uh oh!

joepetrowski commented Jan 19, 2024

Uh oh!

command-bot bot commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jan 19, 2024

Uh oh!

mordamax commented Jan 19, 2024

Uh oh!

command-bot bot commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mordamax commented Jan 19, 2024

Uh oh!

mordamax commented Jan 19, 2024

Uh oh!

command-bot bot commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

command-bot bot commented Jan 19, 2024

Uh oh!

command-bot bot commented Jan 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

command-bot bot commented Jan 18, 2024 •

edited

Loading

command-bot bot commented Jan 19, 2024 •

edited

Loading

command-bot bot commented Jan 19, 2024 •

edited

Loading

command-bot bot commented Jan 19, 2024 •

edited

Loading

command-bot bot commented Jan 19, 2024 •

edited

Loading

command-bot bot commented Jan 19, 2024 •

edited

Loading