Skip to content

proposer: return optional block#2834

Merged
bkchr merged 3 commits intomasterfrom
rh-proposer-option
Jan 4, 2024
Merged

proposer: return optional block#2834
bkchr merged 3 commits intomasterfrom
rh-proposer-option

Conversation

@rphmeier
Copy link
Contributor

@rphmeier rphmeier commented Jan 2, 2024

This opens up the proposer to only optionally create blocks. Nodes may only make blocks when there are transactions or the chain is scheduled.

@rphmeier
proposer: return optional block
7c9fe69 
This opens up the proposer to only optionally create blocks.
Nodes may only make blocks when there are transactions or the chain is scheduled.
@rphmeier rphmeier added T0-node This PR/Issue is related to the topic “node”. R1-breaking_change This PR introduces a breaking change and should be highlighted in the upcoming release. labels Jan 2, 2024
@rphmeier rphmeier mentioned this pull request Jan 2, 2024
Merged
@pepyakin pepyakin requested review from bkchr and sandreim January 2, 2024 14:32
@bkchr
Copy link
Member

bkchr commented Jan 4, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Jan 4, 2024 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4838005 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-deb030d7-eaf1-405a-bfd7-3c190cb7b2b7 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 4, 2024

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4838005 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4838005/artifacts/download.

@bkchr bkchr requested a review from skunert January 4, 2024 08:35
@bkchr bkchr merged commit 19de1c9 into master Jan 4, 2024
@bkchr bkchr deleted the rh-proposer-option branch January 4, 2024 18:57
@kamilsa kamilsa mentioned this pull request Jan 17, 2024
Closed
@fgamundi fgamundi mentioned this pull request Jan 26, 2024
Merged
@github-actions github-actions bot mentioned this pull request Feb 19, 2024
Closed
@fgamundi fgamundi mentioned this pull request Feb 21, 2024
Merged
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
@Aideepakchaudhary Aideepakchaudhary mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skunert skunert skunert approved these changes

@bkchr bkchr bkchr approved these changes

@sandreim sandreim sandreim approved these changes

Assignees

No one assigned

Labels

R1-breaking_change This PR introduces a breaking change and should be highlighted in the upcoming release. T0-node This PR/Issue is related to the topic “node”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rphmeier @bkchr @skunert @sandreim @patriciobcs