Skip to content

🐛 Depositing PalletAttributeSet on incorrect nft #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggwpez merged 9 commits into from
Mar 9, 2024
Merged

🐛 Depositing PalletAttributeSet on incorrect nft #2740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8d8473c
:bug: Depositing PalletAttributeSet on incorrect nft
vikiival Dec 18, 2023
cc28b52
Merge branch 'master' into fix/mint-pallet-attribute
vikiival Feb 21, 2024
535d7e5
Add test
Feb 29, 2024
8da39ac
Merge branch 'master' into fix/mint-pallet-attribute
jsidorenko Feb 29, 2024
3e1d0ae
Merge branch 'master' into fix/mint-pallet-attribute
jsidorenko Feb 29, 2024
c542d33
Merge branch 'master' into fix/mint-pallet-attribute
vikiival Mar 1, 2024
062b3b4
Merge branch 'master' into fix/mint-pallet-attribute
jsidorenko Mar 3, 2024
587aa57
Merge branch 'master' into fix/mint-pallet-attribute
jsidorenko Mar 7, 2024
ed76d73
Merge branch 'master' into fix/mint-pallet-attribute
vikiival Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions substrate/frame/nfts/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,8 +874,8 @@ pub mod pallet {
),
);
Self::deposit_event(Event::PalletAttributeSet {
collection,
item: Some(item),
collection: collection_id,
item: Some(owned_item),
attribute: pallet_attribute,
value: attribute_value,
});
Expand Down
6 changes: 6 additions & 0 deletions substrate/frame/nfts/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,12 @@ fn mint_should_work() {
account(2),
Some(MintWitness { owned_item: Some(43), ..Default::default() })
));
assert!(events().contains(&Event::<Test>::PalletAttributeSet {
collection: 0,
item: Some(43),
attribute: PalletAttributes::<<Test as Config>::CollectionId>::UsedToClaim(1),
value: Nfts::construct_attribute_value(vec![]).unwrap(),
}));

// can't mint twice
assert_noop!(
Expand Down