Skip to content

fix overflow in balance_to_point conversion #2706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkchr merged 3 commits into from
Dec 22, 2023
Merged

fix overflow in balance_to_point conversion #2706

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0015db
fix overflow in `balance_to_point` conversion
Dec 14, 2023
6158a29
Merge branch 'master' into overflow-in-pools
SCJangra Dec 14, 2023
67312da
add overflow tests for `balance_to_point` and `point_to_balance` func…
Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions substrate/frame/nomination-pools/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2955,9 +2955,12 @@ impl<T: Config> Pallet<T> {
},
(false, false) => {
// Equivalent to (current_points / current_balance) * new_funds
balance(u256(current_points).saturating_mul(u256(new_funds)))
// We check for zero above
.div(current_balance)
balance(
u256(current_points)
.saturating_mul(u256(new_funds))
// We check for zero above
.div(u256(current_balance)),
)
},
}
}
Expand Down