Skip to content

Contracts build risc-v fixtures#2554

Merged
pgherveou merged 53 commits intomasterfrom
pg/riscv-fixtures
Jan 4, 2024
Merged

Contracts build risc-v fixtures#2554
pgherveou merged 53 commits intomasterfrom
pg/riscv-fixtures

Conversation

@pgherveou
Copy link
Copy Markdown
Contributor

@pgherveou pgherveou commented Nov 29, 2023 •
edited
Loading

Follow up from #2347 this time to verify that fixtures build to RISC-V

@pgherveou pgherveou requested a review from athei as a code owner November 29, 2023 22:19
@pgherveou pgherveou requested a review from a team November 29, 2023 22:19
@pgherveou pgherveou added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Nov 29, 2023
athei
athei reviewed Nov 30, 2023
View reviewed changes
@pgherveou pgherveou requested a review from xermicus November 30, 2023 12:21
@athei
Copy link
Copy Markdown
Member

athei commented Dec 6, 2023

We should be able to pass CI now. Toolchain should be installed for both macOS and Linux.

@pgherveou
Copy link
Copy Markdown
Contributor Author

pgherveou commented Dec 6, 2023

We should be able to pass CI now. Toolchain should be installed for both macOS and Linux.

Nice will merge master and try to pass these jobs

@pgherveou pgherveou mentioned this pull request Dec 8, 2023
Merged
@pgherveou pgherveou requested a review from a team as a code owner December 8, 2023 16:26
athei
athei reviewed Jan 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@athei athei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the caching code since we get the RISC-V toolchain deployed on the CI?

@pgherveou
Copy link
Copy Markdown
Contributor Author

pgherveou commented Jan 4, 2024

We can remove the caching code since we get the RISC-V toolchain deployed on the CI?

Removed it already, (the tmp hack of checking in the rv compilation output). We only use caching to check if we need to recompile a given fixture now

@athei
Copy link
Copy Markdown
Member

athei commented Jan 4, 2024

Yes my bad. I just read "cache" and thought it was about this. But it is just to prevent re-building all fixtures when only one of them changed. Good to be merged once the CI is green.

@pgherveou pgherveou merged commit f82c297 into master Jan 4, 2024
@pgherveou pgherveou deleted the pg/riscv-fixtures branch January 4, 2024 14:49
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@pgherveou @alvicsam @athei
Contracts build risc-v fixtures (paritytech#2554)
4c7bf9b 
Follow up from paritytech#2347 this time to verify that fixtures build to RISC-V

---------

Co-authored-by: alvicsam <[email protected]>
Co-authored-by: Alexander Samusev <[email protected]>
Co-authored-by: Alexander Theißen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@athei athei athei approved these changes

@xermicus xermicus Awaiting requested review from xermicus

+1 more reviewer

@ascjones ascjones ascjones approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

R0-no-crate-publish-required The change does not require any crates to be re-published.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pgherveou @athei @ascjones @alvicsam