Make RocksDb optional throughout Polkadot and Cumulus#2553
Closed
JoshOrndorff wants to merge 10 commits intoparitytech:masterfrom
Closed
Make RocksDb optional throughout Polkadot and Cumulus#2553JoshOrndorff wants to merge 10 commits intoparitytech:masterfrom
JoshOrndorff wants to merge 10 commits intoparitytech:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many Substrate crates have a
rocksdbfeature that allows faster builds by removing rocks db from the dependency graph. This practice was not extended throughout parts of Cumulus and Polkadot.This meant that parachain projects always had to build RockDb, which consumes time and energy, and now, even makes my github actions runners run out of disk space 😆
This PR, extends the practice of making rocksdb optional throughout Polkadot and cumulus.
Note, that I also discovered a compile problem along the way and reported it in #2551. I need guess I will need a little guidance on that before tidying this one up.