Merged
Conversation
muharem
commented
Nov 28, 2023
| #[allow(deprecated)] | ||
| Treasury::<T, I>::propose_spend(RawOrigin::Signed(caller).into(), value, lookup)?; | ||
| let proposal_id = <ProposalCount<T, I>>::get() - 1; | ||
| #[allow(deprecated)] |
Contributor
Author
There was a problem hiding this comment.
all the changes within the current module backward compatible. we ensure that approve_proposal call can be disabled via ApproveOrigin parameter which results the Weightless error for it's benchmark, with no affect to the rest of the benchmarks.
joepetrowski
approved these changes
Nov 30, 2023
Contributor
joepetrowski
left a comment
joepetrowski
left a comment
There was a problem hiding this comment.
Looks good, just a few questions.
cumulus/parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/fellowship/mod.rs
Outdated
Show resolved
Hide resolved
cumulus/parachains/runtimes/collectives/collectives-westend/src/fellowship/mod.rs
Outdated
Show resolved
Hide resolved
...s/integration-tests/emulated/tests/assets/asset-hub-westend/src/tests/fellowship_treasury.rs
Outdated
Show resolved
Hide resolved
...s/integration-tests/emulated/tests/assets/asset-hub-westend/src/tests/fellowship_treasury.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: joe petrowski <[email protected]>
joepetrowski
added
the
T14-system_parachains
bkchr
approved these changes
Dec 8, 2023
|
The CI pipeline was cancelled due to failure one of the required jobs. |
fellowship-merge-bot bot
pushed a commit
to polkadot-fellows/runtimes
that referenced
this pull request
Dec 8, 2023
Treasury Pallet Instance for the Fellowship in Polkadot Collectives. In this update, we present a Treasury Pallet Instance that is under the control of the Fellowship body, with oversight from the Root and Treasurer origins. Here's how it is governed: - the Root origin have the authority to reject or approve spend proposals, with no amount limit for approvals. - the Treasurer origin have the authority to reject or approve spend proposals, with approval limits of up to 10,000,000 DOT. - Voice of all Fellows ranked at 3 or above can reject or approve spend proposals, with a maximum approval limit of 10,000 DOT. - Voice of Fellows ranked at 4 or above can also reject or approve spend proposals, with a maximum approval limit of 10,000,000 DOT. Additionally, we introduce the Asset Rate Pallet Instance to establish conversion rates from asset A to B. This is used to determine if a proposed spend amount involving a non-native asset is permissible by the commanding origin. The rates can be set up by the Root, Treasurer origins, or Voice of all Fellows. test with xcm-emulator for the same setup in Westend - paritytech/polkadot-sdk#2532 more details on new treasury features and asset rate pallet - paritytech/polkadot-sdk#1333 --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: joepetrowski <[email protected]> Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
5 tasks
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Treasury Pallet Instance for the Fellowship in Westend Collectives. In this update, we present a Treasury Pallet Instance that is under the control of the Fellowship body, with oversight from the Root and Treasurer origins. Here's how it is governed: - the Root origin have the authority to reject or approve spend proposals, with no amount limit for approvals. - the Treasurer origin have the authority to reject or approve spend proposals, with approval limits of up to 10,000,000 DOT. - Voice of all Fellows ranked at 3 or above can reject or approve spend proposals, with a maximum approval limit of 10,000 DOT. - Voice of Fellows ranked at 4 or above can also reject or approve spend proposals, with a maximum approval limit of 10,000,000 DOT. Additionally, we introduce the Asset Rate Pallet Instance to establish conversion rates from asset A to B. This is used to determine if a proposed spend amount involving a non-native asset is permissible by the commanding origin. The rates can be set up by the Root, Treasurer origins, or Voice of all Fellows. --------- Co-authored-by: joe petrowski <[email protected]> Co-authored-by: joepetrowski <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treasury Pallet Instance for the Fellowship in Westend Collectives.
In this update, we present a Treasury Pallet Instance that is under the control of the Fellowship body, with oversight from the Root and Treasurer origins. Here's how it is governed:
Additionally, we introduce the Asset Rate Pallet Instance to establish conversion rates from asset A to B. This is used to determine if a proposed spend amount involving a non-native asset is permissible by the commanding origin. The rates can be set up by the Root, Treasurer origins, or Voice of all Fellows.