Skip to content

Add warning when peer_id is not available when building topology #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkchr merged 4 commits into from
Nov 6, 2023
Merged

Add warning when peer_id is not available when building topology #2140

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
463bde0
Add warning when peer_id is not available when building topology
alexggh Nov 2, 2023
3a348de
Add issue in log
alexggh Nov 3, 2023
b311278
Update polkadot/node/network/bridge/src/rx/mod.rs
alexggh Nov 5, 2023
1b15a54
Merge branch 'master' into alexaghh/warn_on_peer_id_not_available
alexggh Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions polkadot/node/network/bridge/src/rx/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,14 @@ where
let mut peers = Vec::with_capacity(neighbors.len());
for (discovery_id, validator_index) in neighbors {
let addr = get_peer_id_by_authority_id(ads, discovery_id.clone()).await;
if addr.is_none() {
// See on why is not good in https://github.com/paritytech/polkadot-sdk/issues/2138
gum::warn!(
target: LOG_TARGET,
?validator_index,
"Could not determine peer_id for validator"
)
}
peers.push(TopologyPeerInfo {
peer_ids: addr.into_iter().collect(),
validator_index,
Expand Down