Skip to content

Sort the benchmarks before listing them #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggwpez merged 3 commits into from
Oct 25, 2023
Merged

Sort the benchmarks before listing them #2026

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f4ff53
Sort the benchmarks before listing them.
ggwpez Oct 25, 2023
5dae4a0
typo
ggwpez Oct 25, 2023
2d182a5
Also dedub
ggwpez Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion substrate/utils/frame/benchmarking-cli/src/pallet/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,13 +748,17 @@ impl CliConfiguration for PalletCmd {

/// List the benchmarks available in the runtime, in a CSV friendly format.
fn list_benchmark(
benchmarks_to_run: Vec<(
mut benchmarks_to_run: Vec<(
Vec<u8>,
Vec<u8>,
Vec<(BenchmarkParameter, u32, u32)>,
Vec<(String, String)>,
)>,
) {
// Sort and de-dub by pallet and function name.
benchmarks_to_run.sort_by(|(pa, sa, _, _), (pb, sb, _, _)| (pa, sa).cmp(&(pb, sb)));
benchmarks_to_run.dedup_by(|(pa, sa, _, _), (pb, sb, _, _)| (pa, sa) == (pb, sb));

println!("pallet, benchmark");
for (pallet, extrinsic, _, _) in benchmarks_to_run {
println!("{}, {}", String::from_utf8_lossy(&pallet), String::from_utf8_lossy(&extrinsic));
Expand Down